Fix a few correctness bugs flagged by SpotBugs (static analysis)#161
Open
vejtom wants to merge 2 commits into
Open
Fix a few correctness bugs flagged by SpotBugs (static analysis)#161vejtom wants to merge 2 commits into
vejtom wants to merge 2 commits into
Conversation
ato
requested changes
Jun 19, 2026
ato
left a comment
Member
There was a problem hiding this comment.
The other changes look good to me.
Author
|
Thank you @ato, should be OK now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran SpotBugs over the code and a handful of CORRECTNESS warnings looked like real bugs. Small fixes below:
Build passes locally.