Skip to content

Fix a few correctness bugs flagged by SpotBugs (static analysis) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vejtom wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

Fix a few correctness bugs flagged by SpotBugs (static analysis) #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e464ce5
fix: fix correctness bugs flagged by SpotBugs
vejtom Jun 18, 2026
b55877f
MetaData: move putChild into the else branch (review feedback)
vejtom Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/archive/format/gzip/GZIPDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public long alignOnMagic3(InputStream is) throws IOException {
// !??
// nope. are the next 2 possibilities?
if((lookahead[1] == GZIP_MAGIC_ONE) &&
(lookahead[2] == GZIP_MAGIC_TWO)) {
((lookahead[2] & 0xff) == GZIP_MAGIC_TWO)) {
// !12
keep = 2;
} else if(lookahead[2] == GZIP_MAGIC_ONE) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/archive/resource/MetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public MetaData(MetaData parentMetaData, String name) {
this.topMetaData = this;
} else {
topMetaData = parentMetaData.topMetaData;
parentMetaData.putChild(name, this);
}
parentMetaData.putChild(name, this);
}

public MetaData(String jsonString) throws JSONException {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/archive/util/ByteOp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public static String drawHex(byte[] b, int bytesPerRow) {
return drawHex(b,0,b.length,bytesPerRow);
}
public static String drawHex(byte[] b, int offset, int length, int bytesPerRow) {
int rows = (int) Math.ceil(length / bytesPerRow);
int rows = (int) Math.ceil((double) length / bytesPerRow);
if(rows == 0) {
rows = 1;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/archive/util/StreamCopy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static long copy(InputStream i, OutputStream o, int bytes) throws IOExcep
}

public static long copyLength(InputStream i, OutputStream o, long bytes) throws IOException {
return copyLength(i,o,DEFAULT_READ_SIZE);
return copyLength(i,o,bytes,DEFAULT_READ_SIZE);
}

public static long copyLength(InputStream i, OutputStream o, long bytes, int readSize) throws IOException {
Expand Down