Themr breaks shouldComponentUpdate shallow equal optimization #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add fix. |
|
|
raveclassic
suggested changes
Sep 26, 2016
There was a problem hiding this comment.
To recall #25 I should note that I don't see any reasons of including these changes because IMO it's not responsibility of themr to handle pure-rendering out of the box.
| : this.getThemeNotComposed(props) | ||
| } | ||
|
|
||
| componentWillReceiveProps(nextProps) { |
There was a problem hiding this comment.
How do you handle context here? Seems like component won't react on changing its theme in context. Even without pure-rendering optimization.
There was a problem hiding this comment.
After breif dicussion with @istarkov it seems that ThemeProvider should have some kind of notification mechanism to notify themed components about context changes. This is out of scope of this PR.
|
Here's a quickfix |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add failing test showing #25