Filter themr props #27
Merged
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istarkov
reviewed
Oct 3, 2016
|
|
||
| if (optionWithRef) { | ||
| renderedElement = React.createElement(ThemedComponent, { | ||
| ...this.props, | ||
| ...props, | ||
| ref: 'wrappedInstance', | ||
| theme: this.theme_ |
There was a problem hiding this comment.
Why theme prop itself is not a problem?
There was a problem hiding this comment.
Almost everywhere it is extracted: const {theme, ...props} = this.props; return <input {...props}/>;
|
Thanks I missed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #26 props are now passed unfiltered including
themr-only props likecomposeThemeandthemeNamespace.If you have a component-wrapper that passes all props to native component (for example native
<input/>) via object spread (<input {...this.props}/>), React complains about unknown prop:Warning: Unknown prop 'composeTheme' on <input> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-propThis PR aims on fixing this problem.