Fixed issue 1375#1354
Conversation
|
Thanks, BradBroulik! Also, can you resubmit the controlgroup tests as a pull that we can review and merge on its own merit? That'd be really helpful. Thanks again! |
|
okay, not sure but it looks like the controlgroup tests were in already: https://github.com/jquery/jquery-mobile/tree/master/tests/unit/controlgroup. Hmm. I guess we just need the dialog theming stuff then. |
|
I'll take a look at the two dialogs and try to get them in sync. Thanks, From: scottjehl reply@reply.github.com Thanks, BradBroulik! Also, can you resubmit the controlgroup tests as a pull that we can review and merge on its own merit? That'd be really helpful. Thanks again! Reply to this email directly or view it on GitHub: |
|
Hi Scott, I just submitted a pull request titled "Fixed dialog theme inheritance (issue 1375)" that should fix the dialog theme inheritance. Please review when you have time: #2108 Thanks, From: scottjehl reply@reply.github.com Thanks, BradBroulik! Also, can you resubmit the controlgroup tests as a pull that we can review and merge on its own merit? That'd be really helpful. Thanks again! Reply to this email directly or view it on GitHub: |
Fixed the dialog theme inheritance (issue 1375).