Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

fix height issue for transitioning page#1723

Merged
scottjehl merged 2 commits intojquery-archive:masterfrom
eddiemonge:bug_1507
May 27, 2011
Merged

fix height issue for transitioning page#1723
scottjehl merged 2 commits intojquery-archive:masterfrom
eddiemonge:bug_1507

Conversation

@eddiemonge
Copy link
Contributor

IE doesnt like min-height

.ui-page should also have min-height 100% defined all the time, not just on page transition, to get rid of weird effects on page transitions

scottjehl pushed a commit that referenced this pull request May 27, 2011
fix height issue for transitioning page
@scottjehl scottjehl merged commit bb67018 into jquery-archive:master May 27, 2011
@jblas
Copy link
Contributor

jblas commented Jun 3, 2011

@eddiemonge

After discussing this with todd and scott, we decided to back this out:

#1770

What is the original issue that this was trying to address? Is there one filed? If so, can you re-open it?

@barbalex
Copy link

I have the exact same problem as jammus. Since changing from 1.a41 to 1.beta1 my Google maps break.
See also http://forum.jquery.com/topic/googlemaps-work-in-1a4-1-not-in-1beta1#14737000002522715
Unfortunately the !important flag does not help.
I managed to repair with:
contentHeight = $(window).height() - 43;
$("#map_canvas").css("height", contentHeight + "px");

npmcomponent pushed a commit to npmcomponent/cbou-jquery-mobile that referenced this pull request Jan 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants