This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fixed iPad Positioning Bug#264
Closed
JeffreyWay wants to merge 14 commits intojquery-archive:masterfrom
JeffreyWay:master
Closed
Fixed iPad Positioning Bug#264JeffreyWay wants to merge 14 commits intojquery-archive:masterfrom JeffreyWay:master
JeffreyWay wants to merge 14 commits intojquery-archive:masterfrom
JeffreyWay:master
Conversation
…the new unHashedSelectors var. So far, this only includes [data-rel=dialog]
- allowed prevention of hash listening during a particular hash change - allowed $.activePage to remain set on previous page when an untracked page is open (return pageshow event false to use this feature) - moved setting and resetting to base urls and made sure they update at the right moment for both new pages and those previously visited. - changePage now accepts an array as first argument, allowing you to specify both [from,to] pages, whereas non-array types would refer to the "to" page, assuming "from" should be the currently viewed page - error requests never generate a hash change now - edited the ajax error to appear in the right location when scrolled Essentially, plugins can now create page changes that are not tracked in history, which is a dialog critical bug.
Conflicts: js/jquery.mobile.js
|
Removed the ajaxClick function and moved its logic into the live click event handler, where it is now refactored and simplified. Thx to Jeffrey Way for ideas that went into this refactor. Also, clicks that are triggered on anchors will now be able to make a new http request, which improves listview behavior when clicking LIs that resolve to external urls. Included in commit is a new demo/test page with various link types to make sure they behave as expected. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be some strange bug where, on the iPad, icons/thumbnails were being positioning in relation to the window, rather than their positioned parent (weird). This forced all of the icons into the top-left corner of the window (on the iPad).
I narrowed the glitch down to the ".ui-li .ui-btn-text" selector (listview.css). The overflow:hidden section was causing the glitch. Setting the value to "visible" for the iPad fixes it.