Conversation
|
Thank you for your contribution! It looks like you haven't signed our CLA. Could you do so at http://contribute.jquery.org/CLA/ Thank you in advance. |
|
It should be signed now.
|
|
This pull-request also fixes #6746 |
There was a problem hiding this comment.
should be spaces inside each set of parentheses
|
In addition to the above comments can you please see http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines for proper formatting of your commit messages. and if you have any questions about the spacing or our style guide in general you can see http://contribute.jquery.org/style-guide/js/ for our js style guide One last thing is this also needs a test added to ensure no future regressions with this issue. once you update the PR please comment and i will look again ( i don't get a notification you updated if you don't comment ) |
|
@mnaughto do you plan on updating this? |
|
I've made the requested modifications in #7237. |
These changes should fix the issue.