Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Issue 6810#6811

Closed
mnaughto wants to merge 2 commits intojquery-archive:masterfrom
mnaughto:issue-6810
Closed

Issue 6810#6811
mnaughto wants to merge 2 commits intojquery-archive:masterfrom
mnaughto:issue-6810

Conversation

@mnaughto
Copy link

These changes should fix the issue.

@gseguin
Copy link
Contributor

gseguin commented Dec 18, 2013

@mnaughto,

Thank you for your contribution! It looks like you haven't signed our CLA. Could you do so at http://contribute.jquery.org/CLA/ Thank you in advance.

@mnaughto
Copy link
Author

It should be signed now.

On Dec 18, 2013, at 15:46, Ghislain Seguin notifications@github.com wrote:

@mnaughto,

Thank you for your contribution! It looks like you haven't signed our CLA. Could you do so at http://contribute.jquery.org/CLA/ Thank you in advance.


Reply to this email directly or view it on GitHub.

@fjsj
Copy link

fjsj commented Dec 19, 2013

This pull-request also fixes #6746

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be spaces inside each set of parentheses

@arschmitz
Copy link
Contributor

In addition to the above comments can you please see http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines for proper formatting of your commit messages. and if you have any questions about the spacing or our style guide in general you can see http://contribute.jquery.org/style-guide/js/ for our js style guide

One last thing is this also needs a test added to ensure no future regressions with this issue.

once you update the PR please comment and i will look again ( i don't get a notification you updated if you don't comment )

@arschmitz
Copy link
Contributor

@mnaughto do you plan on updating this?

@gabrielschulhof
Copy link

I've made the requested modifications in #7237.

gabrielschulhof pushed a commit that referenced this pull request Mar 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants