This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix getPath issues that arise on Android 4.4#7237
Closed
gabrielschulhof wants to merge 2 commits intomasterfrom
Closed
Fix getPath issues that arise on Android 4.4#7237gabrielschulhof wants to merge 2 commits intomasterfrom
gabrielschulhof wants to merge 2 commits intomasterfrom
Conversation
Closed
Contributor
|
👍 |
Author
|
In the end, we couldn't reproduce the issue, so I'm going to close this PR. In #7263, which fixes #6574 and #6599 we remove the assumption that // has to be added to a protocol, and instead rely on the parser to split of // from the URL if present, and then re-assemble the URL with the value parsed. If the location object is ever whacky on any platform we support, we need only modify getLocation() to restrict its usage of the location object to location.href, and use our regex parser to construct an object similar to the location object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to PR #6811. It includes the changes in that PR, and it fixes the spacing issues.