Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Add GitHub Actions testing, JSHint -> ESLint, rewrite tests in ESM #16

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

mgol
Copy link
Contributor

@mgol mgol commented Apr 5, 2024

Also:

  • switch to Node 20
  • update dependencies

@mgol mgol self-assigned this Apr 5, 2024
@mgol mgol requested review from timmywil and fnagel April 5, 2024 23:03
matrix:
NAME: ["Node"]
NODE_VERSION: [20.x]
NPM_SCRIPT: ["test"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use a matrix here. I suggest using env to set the node version, setting the workflow name statically. NPM_SCRIPT is already unused below.

Copy link
Contributor Author

@mgol mgol Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to switch to env and it looks similar to what you did in jQuery UI but it just doesn't work. I have a test PR at mgol#2 and I am getting the following error:

The workflow is not valid. .github/workflows/node.js.yml (Line: 17, Col: 11): Unrecognized named-value: 'env'. Located at position 1 within expression: env.NODE_VERSION

That line is literally:

    name: test (${{ env.NODE_VERSION }})

Any ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh; apparently, env variables cannot be used outside steps. I removed the usage from that single line and it's green now: https://github.com/mgol/jquery-ui-themeroller/actions/runs/8584283401/job/23524385015?pr=2

@mgol mgol force-pushed the updates branch 4 times, most recently from 9a7abd0 to befbb5a Compare April 6, 2024 22:38
@mgol mgol requested a review from timmywil April 6, 2024 22:40
@mgol mgol merged commit 69d5123 into jquery-archive:main Apr 7, 2024
1 check passed
@mgol mgol deleted the updates branch April 7, 2024 21:36
@mgol mgol mentioned this pull request Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants