Skip to content

Upgrade examples to jQuery 3 #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Sep 19, 2016 · 3 comments · Fixed by #1148
Closed

Upgrade examples to jQuery 3 #982

mgol opened this issue Sep 19, 2016 · 3 comments · Fixed by #1148
Assignees
@mgol
Milestone
3.0.0

Comments

@mgol
Copy link
Member

mgol commented Sep 19, 2016

Currently our examples use the really, really old jQuery 1.10.2 (it's over 3 years old). We should update them to jQuery 3 (currently 3.1.0). This means we will have to remove examples using removed APIs but I think we should do that anyway; such entries should be short and mostly focus on what to switch to, we shouldn't making it easier for people to use deprecated APIs.

The jQuery used in examples is included here: https://github.com/jquery/api.jquery.com/blob/a6f6b37/entries2html.xsl#L15.
@mgol
Copy link
Member Author

mgol commented Sep 19, 2016

Note that the jQuery used by examples is a different one to the one used by our sites; the latter is managed globally in the jquery-wp-content repo, here: https://github.com/jquery/api.jquery.com/blob/a6f6b37/entries2html.xsl#L15

@mgol
Copy link
Member Author

mgol commented Sep 19, 2016

The issue about upgrading jQuery on our sites is here: jquery/jquery-wp-content#400

cc @dmethvin @timmywil

@mgol mgol self-assigned this Sep 2, 2019
mgol added a commit to mgol/api.jquery.com that referenced this issue Sep 2, 2019
@mgol
All: Upgrade jQuery used in examples from 1.10.2 to 3.4.1, remove dep…
5c43f34 
…recated examples

The upgrade is necessary to be able to write examples for newer APIs.
Examples for removed APIs have been removed as they'd no longer work.

Fixes jquerygh-982
mgol added a commit to mgol/api.jquery.com that referenced this issue Sep 2, 2019
@mgol
All: Upgrade jQuery used in examples from 1.10.2 to 3.4.1, remove dep…
fa9ce1c 
…recated examples

The upgrade is necessary to be able to write examples for newer APIs.
Examples for removed APIs have been removed as they'd no longer work.

Fixes jquerygh-982
mgol added a commit to mgol/api.jquery.com that referenced this issue Sep 2, 2019
@mgol
All: Upgrade jQuery used in examples from 1.10.2 to 3.4.1, remove dep…
b6f2cfa 
…recated examples

The upgrade is necessary to be able to write examples for newer APIs.
Examples for removed APIs have been removed as they'd no longer work.

Fixes jquerygh-982
@mgol mgol mentioned this issue Sep 2, 2019
Merged
@mgol
Copy link
Member Author

mgol commented Sep 2, 2019

PR: #1148

@mgol mgol added this to the 3.0.0 milestone Sep 2, 2019
@mgol mgol mentioned this issue Sep 2, 2019
Closed
@mgol mgol closed this as completed in #1148 Sep 3, 2019
mgol added a commit that referenced this issue Sep 3, 2019
@mgol
All: Upgrade jQuery used in examples from 1.10.2 to 3.4.1
b905a92 
The upgrade is necessary to be able to write examples for newer APIs.
Examples for removed APIs have been removed as they'd no longer work.

Fixes gh-982
Closes gh-1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
None yet
Milestone
3.0.0
1 participant
@mgol