Skip to content

CSS: Make it clear !important is not guaranteed to not work with .css() #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2021
Merged

CSS: Make it clear !important is not guaranteed to not work with .css() #1188

merged 1 commit into from
May 17, 2021

Conversation

mgol
Copy link
Member

@mgol mgol commented May 13, 2021

This is so that we can add support in a minor release without treating it as a breaking change.

@mgol mgol requested review from timmywil and gibson042 May 13, 2021 13:45
@mgol mgol force-pushed the css-important branch from 203b617 to d209631 Compare May 13, 2021 13:53
timmywil
timmywil approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol merged commit 2eec5a9 into jquery:main May 17, 2021
@mgol mgol deleted the css-important branch May 17, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil