Skip to content

Added structured types for higer order function parameters #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esx wants to merge 10 commits into from
Closed

Added structured types for higer order function parameters #419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b82bc18
Added structured types for higer order function parameters
esx Jan 18, 2014
d8093a5
Changed some argument type from XMLHttpRequest to jsXHR
esx Jan 18, 2014
0d7d9b3
Fixed spelling and changed 'ajaxOptions' to 'PlainObject'
esx Jan 18, 2014
7455ae5
Fix spelling in type attribute
esx Jan 18, 2014
d68f7ae
Changed nargument names to valid identifers to avoid confusion
esx Jan 19, 2014
41ce261
Changed argument name 'jQueryObject' to 'selection'
esx Jan 21, 2014
6aa5119
Some fixies in signatures
esx Feb 13, 2014
9d4aa93
Name fix
esx Feb 13, 2014
49a296c
Clarify jQuery.map
esx Feb 17, 2014
40db666
Signature fixes for $.each() and prop()
esx May 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed spelling and changed 'ajaxOptions' to 'PlainObject' 
The ajaxOptions/ajaxSettings options object is not documented as a
seperate type, so now changed to PlainObject. Changed misspelling of
jsXHR to jqXHR.
  • Loading branch information
@esx
esx committed Jan 18, 2014
commit 0d7d9b303f46db2ffb00d336e1a0fd20eec02fd8
4 changes: 2 additions & 2 deletions entries/ajaxComplete.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<added>1.0</added>
<argument name="handler" type="Function">
<argument name="event" type="Event" />
<argument name="jsXHR" type="jsXHR" />
<argument name="ajaxOptions" type="ajaxOptions" />
<argument name="jqXHR" type="jqXHR" />
<argument name="ajaxOptions" type="PlainObject" />
<desc>The function to be invoked.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/ajaxError.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<desc>The function to be invoked.</desc>
<argument name="event" type="Event" />
<argument name="jqXHR" type="jqXHR" />
<argument name="ajaxSettings" type="ajaxSettings" />
<argument name="ajaxSettings" type="PlainObject" />
<argument name="thrownError" type="Error" />
Copy link
Member

@tjvantoll tjvantoll Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Error object on the Types page. Also I got a String for this argument.

</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/ajaxSend.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<desc>The function to be invoked.</desc>
<argument name="event" type="Event" />
<argument name="jqXHR" type="jqXHR" />
<argument name="ajaxOptions" type="ajaxOptions" />
<argument name="ajaxOptions" type="PlainObject" />
</argument>
</signature>
<desc>Attach a function to be executed before an Ajax request is sent. This is an <a href="/Ajax_Events/">Ajax Event</a>.</desc>
Expand Down
4 changes: 2 additions & 2 deletions entries/ajaxSuccess.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<argument name="handler" type="Function">
<desc>The function to be invoked.</desc>
<argument name="event" type="Event" />
<argument name="jsXHR" type="jsXHR" />
<argument name="ajaxOptions" type="ajaxOptions" />
<argument name="jqXHR" type="jqXHR" />
<argument name="ajaxOptions" type="PlainObject" />
Copy link
Member

@tjvantoll tjvantoll Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a fourth argument here that has the results of the call.

</argument>
</signature>
<desc>Attach a function to be executed whenever an Ajax request completes successfully. This is an <a href="/Ajax_Events/">Ajax Event</a>.</desc>
Expand Down
4 changes: 2 additions & 2 deletions entries/jQuery.ajaxPrefilter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
</argument>
<argument name="handler" type="Function">
<desc>A handler to set default values for future Ajax requests.</desc>
<argument name="options" type="ajaxOptions" />
<argument name="originalOptions" type="ajaxOptions" />
<argument name="options" type="PlainObject" />
<argument name="originalOptions" type="PlainObject" />
<argument name="jqXHR" type="jqXHR" />
</argument>
</signature>
Expand Down
4 changes: 2 additions & 2 deletions entries/jQuery.ajaxTransport.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
</argument>
<argument name="handler" type="Function">
<desc>A handler to return the new transport object to use with the data type provided in the first argument.</desc>
<argument name="options" type="ajaxOptions" />
<argument name="originalOptions" type="ajaxOptions" />
<argument name="options" type="PlainObject" />
<argument name="originalOptions" type="PlainObject" />
<argument name="jqXHR" type="jqXHR" />
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/load.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<argument name="complete" type="Function" optional="true">
<argument name="responseText" type="String" />
<argument name="textStatus" type="String"/>
<argument name="jsXHR" type="jsXHR"/>
<argument name="jqXHR" type="jqXHR"/>
<desc>A callback function that is executed when the request completes.</desc>
</argument>
</signature>
Expand Down