Skip to content

Added structured types for higer order function parameters #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esx wants to merge 10 commits into from
Closed

Added structured types for higer order function parameters #419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b82bc18
Added structured types for higer order function parameters
esx Jan 18, 2014
d8093a5
Changed some argument type from XMLHttpRequest to jsXHR
esx Jan 18, 2014
0d7d9b3
Fixed spelling and changed 'ajaxOptions' to 'PlainObject'
esx Jan 18, 2014
7455ae5
Fix spelling in type attribute
esx Jan 18, 2014
d68f7ae
Changed nargument names to valid identifers to avoid confusion
esx Jan 19, 2014
41ce261
Changed argument name 'jQueryObject' to 'selection'
esx Jan 21, 2014
6aa5119
Some fixies in signatures
esx Feb 13, 2014
9d4aa93
Name fix
esx Feb 13, 2014
49a296c
Clarify jQuery.map
esx Feb 17, 2014
40db666
Signature fixes for $.each() and prop()
esx May 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed argument name 'jQueryObject' to 'selection' 
As per discussion on #jquery-content. Also changed type from 'Object'
to 'jQuery' where prose indicates a jQuery object.
  • Loading branch information
@esx
esx committed Jan 21, 2014
commit 41ce2612838d41a781e27324f04745b92dbbc0af
2 changes: 1 addition & 1 deletion entries/closest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</signature>
<signature>
<added>1.6</added>
<argument name="jQueryObject" type="jQuery">
<argument name="selection" type="jQuery">
Copy link
Member

@tjvantoll tjvantoll Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the purpose of this change? I'm not seeing any effect that it's having.

Copy link
Member

@scottgonzalez scottgonzalez Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose is to avoid confusion when reading the example by using a proper variable name (no spaces). There was a discussion about what that name should be (I think in IRC) and I believe we opted for selection, though I believe even within this PR there are inconsistencies.

Copy link
Member

@tjvantoll tjvantoll Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like @esx added this commit after I last pulled in this branch. That's why I wasn't seeing the changes in my local environment. @esx could you make a pass of this and make sure that you're being consistent with "selection"?

Thanks.

<desc>A jQuery object to match elements against.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/filter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</signature>
<signature>
<added>1.4</added>
<argument name="jQueryObject" type="Object">
<argument name="selection" type="jQuery">
<desc>An existing jQuery object to match the current set of elements against.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/find.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</signature>
<signature>
<added>1.6</added>
<argument name="jQuery" type="jQuery">
<argument name="selection" type="jQuery">
<desc>A jQuery object to match elements against.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/is.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</signature>
<signature>
<added>1.6</added>
<argument name="jQueryObject" type="Object">
<argument name="selection" type="jQuery">
Copy link
Member

@tjvantoll tjvantoll Jan 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still displaying as "Type: Object" rather than "Type: jQuery" for me.

<desc>An existing jQuery object to match the current set of elements against.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/jQuery.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</signature>
<signature>
<added>1.0</added>
<argument name="jQueryObject" type="jQuery">
<argument name="selection" type="jQuery">
<desc>An existing jQuery object to clone.</desc>
</argument>
</signature>
Expand Down
2 changes: 1 addition & 1 deletion entries/not.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</signature>
<signature>
<added>1.4</added>
<argument name="jQueryObject" type="jQuery">
<argument name="selection" type="jQuery">
<desc>An existing jQuery object to match the current set of elements against.</desc>
</argument>
</signature>
Expand Down