-
Notifications
You must be signed in to change notification settings - Fork 264
Update one.xml - Fixed ambiguity in sample code string #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Text on selector is ambigious to it's actual functionality. Changed from sounding like "the click on #foo had to be the first click in the document" to "the first click on #foo" jsfiddle for playground/proof: http://jsfiddle.net/B3zNn/1/
Totally missed the text before this too (in quote below) - sounds like the original text was intentional, but that the functionality in the jsfiddle differs... Not sure if this is a jQuery bug request and/or a doc change
|
I think this is actually a docs bug. @dmethvin Can you confirm the intended behavior? |
The docs are correct as-is. The text in the body clarify what is going on if the example isn't totally clear. If there is no Even if we tried to handle this by waiting for a |
@dmethvin The fiddle says otherwise; tested with 1.7.2, 1.8.3, 1.9.1, 1.10.1, 1.11.0, and 2.x. |
Ok then I'll need to puzzle it out later. |
Posting a more comprehensive fiddle for ref per Dave's "if #foo doesn't exist" use case: http://jsfiddle.net/B3zNn/10/ |
From its introduction to its current implementation, |
Merged this in because it seems like the minor change to the docs is preferable to a possibly breaking change to the code. @dmethvin, let me know if you think anything else needs to be done here. |
Per @gibson042, I think the doc fix is preferred. Made the preceding paragraph to this fix consistent per the second comment here in #519 |
Thanks, Tom. We should be all good now. |
Text on selector is ambigious to it's actual functionality. Changed from sounding like "the click on #foo had to be the first click in the document" to "the first click on #foo in the document"
jsfiddle for playground/proof: http://jsfiddle.net/B3zNn/1/