one(): Fix description of behavior for delegated .one() events #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,13 +44,13 @@ | |||
| </argument> | |||
| </signature> | |||
| <longdesc> | |||
| <p>The first form of this method is identical to <code>.bind()</code>, except that the handler is unbound after its first invocation. The second two forms, introduced in jQuery 1.7, are identical to <code>.on()</code> except that the handler is removed after the first time the event occurs at the delegated element, whether the selector matched anything or not. For example:</p> | |||
| <p>The first and second forms of this method are respectively identical to <code>.bind()</code> and <code>.on()</code>, except that the handler is unbound in each after its first invocation. For example:</p> | |||
There was a problem hiding this comment.
I think we can drop the comparison to .bind() altogether and instead just have: "The .one() method is identical to .on(), except that…"
Refs #489 (specifically #issuecomment-42754794) and updates the preceding paragraph appropriately.
|
@kswedberg - Love it! Rebased w/ feedback + removed now redundant second code block. |
|
Excellent. Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #489 (specifically #issuecomment-42754794) and updates the preceding paragraph appropriately.