-
Notifications
You must be signed in to change notification settings - Fork 261
Update jQuery.ajax.xml #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix issue jquery#609
|
I think we prefer |
|
I'd say that it's |
|
For people switching between native and jQuery usage, the |
|
Yeah, I think we should prefer |
Updated PR based on the discussion.
|
PR updated. |
|
Wow. Looks good, @AurelioDeRosa. I'm wondering if we should update all of our examples too. |
|
I agree that we should update the examples too. I'll update the PR again. |
|
You rock, @AurelioDeRosa. |
entries/jQuery.ajax.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it was just takeover from the type option, but some nitpicks.
default is "GET".
Seems like weird to say this again, as we already indicate that just a line above that: http://gyazo.com/3e298875859e35d8dfdcef35f71ab3ac
(e.g. "POST", "GET", "PUT")
Maybe wrap these in <code> elements.
|
Looks good. Merging. |
Fix issue #609