Skip to content

Update jQuery.ajax.xml #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AurelioDeRosa wants to merge 3 commits into from
Closed

Update jQuery.ajax.xml #671

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ace1f59
Update jQuery.ajax.xml
AurelioDeRosa Feb 28, 2015
8887ca1
Update jQuery.ajax.xml
AurelioDeRosa Mar 9, 2015
8e639fa
Update jQuery.ajax.xml
AurelioDeRosa Mar 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update jQuery.ajax.xml 
Updated PR based on the discussion.
  • Loading branch information
@AurelioDeRosa
AurelioDeRosa committed Mar 9, 2015
commit 8887ca124f7e005d5a56a883449b5c9adde64bb5
4 changes: 2 additions & 2 deletions entries/jQuery.ajax.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ $.ajax({
<desc>Specify the callback function name for a JSONP request. This value will be used instead of the random name automatically generated by jQuery. It is preferable to let jQuery generate a unique name as it'll make it easier to manage the requests and provide callbacks and error handling. You may want to specify the callback when you want to enable better browser caching of GET requests. <strong>As of jQuery 1.5</strong>, you can also use a function for this setting, in which case the value of <code>jsonpCallback</code> is set to the return value of that function. </desc>
</property>
<property default="'GET'" name="method" type="String" added="1.9.0">
<desc>An alias for <code>type</code>.</desc>
<desc>The HTTP method to use for the request (e.g. "POST", "GET", "PUT"); default is "GET".</desc>
Copy link
Member

@arthurvr arthurvr Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was just takeover from the type option, but some nitpicks.

default is "GET".

Seems like weird to say this again, as we already indicate that just a line above that: http://gyazo.com/3e298875859e35d8dfdcef35f71ab3ac

(e.g. "POST", "GET", "PUT")

Maybe wrap these in <code> elements.

</property>
<property name="mimeType" type="String" added="1.5.1">
<desc>A mime type to override the <abbr title="XMLHttpRequest">XHR</abbr> mime type.</desc>
Expand Down Expand Up @@ -147,7 +147,7 @@ $.ajax({
<desc>Set this to <code>true</code> if you wish to use the traditional style of <a href="/jQuery.param/">param serialization</a>.</desc>
</property>
<property default="'GET'" name="type" type="String">
<desc>The type of request to make (e.g. "POST", "GET", "PUT"); default is "GET". </desc>
<desc>An alias for <code>method</code>. You should use <code>type</code> if you're using versions of jQuery prior to 1.9.0.</desc>
</property>
<property default="The current page" name="url" type="String">
<desc> A string containing the URL to which the request is sent.</desc>
Expand Down