Skip to content

Added .editorconfig file #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

AurelioDeRosa
Copy link
Member

.editorconfig file taken directly from jQuery's repository.

@scottgonzalez
Copy link
Member

It's kinda silly to do a direct copy from a different project with different types of files and a different directory structure. Half of these rules are for files that don't even exist, and the majority of the files in this repo don't even get indentation rules applied to them.

@AurelioDeRosa
Copy link
Member Author

For the benefit of solving this issue, it'd be great if you could point on specific lines that you'd like to change/add/remove. By doing so, we can have a change that works for everyone and improve the status quo. In its current state your comment doesn't really help.

@kswedberg
Copy link
Member

@AurelioDeRosa: why bother specifying [**/.js], [**.xml], etc.? Is there a type of file in which we don't use indent_style = tab? I think having one indent_style = tab along with the other rules should be sufficient. Or am I missing something?

@scottgonzalez
Copy link
Member

I think having one indent_style = tab along with the other rules should be sufficient. Or am I missing something?

Right, almost everything is tab indented, so having that be the default would make sense. package.json and *.yml should be set to two spaces though.

trim_trailing_whitespace = true
insert_final_newline = true

# Tabs in JS unless otherwise specified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing else specified.

@mgol
Copy link
Member

mgol commented Mar 22, 2017

@AurelioDeRosa It seems to me that current version of Core's .editorconfig would be a good fit, the only modification needed is to apply 2 spaces to *.yml files as well as @scottgonzalez indicated.

Would you like to do it? If not, I'd close this PR and I can do it separately.

@mgol
Copy link
Member

mgol commented Aug 1, 2018

@AurelioDeRosa ping

Base automatically changed from master to main February 1, 2021 22:04
@Krinkle Krinkle closed this in e0244b0 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants