-
Notifications
You must be signed in to change notification settings - Fork 481
Added .editorconfig file #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kswedberg Could you please have a look? I'm wondering whether we need an entry for each of package.json and *.yml to be set to two spaces? |
If that's the spacing we are using for those files (and that is the spacing that npm uses for package.json) I would agree that we should add those to the .editorconfig |
@gnarf Thank you very much for checking. @AurelioDeRosa would you be able to add this? Thank you so much! |
So, based on the OP and comments above, I think it might be a bit more "DRY" to do it like this:
Thoughts, @AurelioDeRosa , @scottgonzalez , @gnarf, anyone? |
I think we can combine the second and third sections and use:
|
I would limit to |
Something like?
|
I think it's a lot clearer to just list the stuff twice for that... no reason to like not copy/pasta two lines of indent/size settings...
feels a lot easier to understand at a glance than using the not as well known |
Fine @gnarf. So I'd say that the final file should be:
If everyone is happy, I'll make a final PR and then merge. |
LGTM! Thanks for sticking with this, @AurelioDeRosa . |
File updated. Any further comment @gnarf and @scottgonzalez? |
👍 |
.editorconfig
file taken directly from jQuery's repository.