Entries: Deprecate page events and note pagecontainer event differences #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR exposes two new pagecontainer events: "pagecontainerbeforeshow" and "pagecontainerbeforehide", which shouldn't be needed because we have "pagecontainerbeforetransition", and "pagecontainertransition", but which have to be documented if we claim that we support the old page events one-to-one with the new pagecontainer widget. |
|
@agcolom i think this looks good but was hoping you could scan over first make sure it sounds good |
|
@gabrielschulhof Thanks! Looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-251