Fix tab example #351
Closed
Fix tab example #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arschmitz Hi Alex, this one is fairly straight forward but whoever merges it will have to resolve conflicts. |
| @@ -8,7 +8,7 @@ | |||
| }</script> | |||
|
|
|||
| <p>This widget is imported unchanged from <a href="http://jqueryui.com/">jQuery UI</a>. Nevertheless, in keeping with jQuery Mobile widget features, the options documented on its jQuery UI API <a href="http://api.jqueryui.com/tabs/">reference</a> page are also available as <code>data-*</code> attributes.</p> | |||
|
|
|||
| <div class="warning"><b>Note:</b> If you are going to use a UI element on the page in conjunction with the tabs widget, do not use a link, as this will interfere with the management of the <code>ui-btn-active</code> class that is used on the tabs. Use other UI elements, such as <code><button></code>, instead.</div> | |||
There was a problem hiding this comment.
Maybe change this to say something more along the lines of "Use of links to open popup's and panels is not currently recommended in conjunction with the tabs widget. Clicking these links will remove the active state style of the selected tab". This is a very specific issue we don't want to make it sounds bigger then it is by implying people should not use links in general with tabs.
There was a problem hiding this comment.
Thanks, Hopefully I'll get a chance to update this today.
|
@arschmitz updated the warning message according to your suggestion |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.