Skip to content

Fix tab example #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agcolom wants to merge 4 commits into from
Closed

Fix tab example #351

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b34afc
Tabs: Fix example to give active state to 1st tab
agcolom Dec 28, 2014
daefae6
Tabs: Fix example to give active state to 1st tab
agcolom Dec 28, 2014
f21ae0a
Tabs: Add note not to use links but buttons
agcolom Dec 28, 2014
1c21dbd
Tabs: Updated warning message using Alex's suggestion
agcolom Feb 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pages/tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}</script>

<p>This widget is imported unchanged from <a href="http://jqueryui.com/">jQuery UI</a>. Nevertheless, in keeping with jQuery Mobile widget features, the options documented on its jQuery UI API <a href="http://api.jqueryui.com/tabs/">reference</a> page are also available as <code>data-*</code> attributes.</p>
Copy link
Member

@arschmitz arschmitz Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related but a good time to update. This is no longer true we now override one of the methods to deal with base tag manipulation.

Copy link
Member

@arschmitz arschmitz Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind thats only for 1.5


<div class="warning"><b>Note:</b> If you are going to use a UI element on the page in conjunction with the tabs widget, do not use a link, as this will interfere with the management of the <code>ui-btn-active</code> class that is used on the tabs. Use other UI elements, such as <code>&lt;button&gt;</code>, instead.</div>
Copy link
Member

@arschmitz arschmitz Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to say something more along the lines of "Use of links to open popup's and panels is not currently recommended in conjunction with the tabs widget. Clicking these links will remove the active state style of the selected tab". This is a very specific issue we don't want to make it sounds bigger then it is by implying people should not use links in general with tabs.

Copy link
Member Author

@agcolom agcolom Jan 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hopefully I'll get a chance to update this today.

<section class="entry-examples" id="entry-examples">
<header><h2>Example:</h2></header>
<div class="entry-example" id="example-0">
Expand All @@ -35,7 +35,7 @@ <h1>jQuery Mobile Example</h1>
<div data-role="tabs">
<div data-role="navbar">
<ul>
<li><a href="#fragment-1">One</a></li>
<li><a href="#fragment-1" class="ui-btn-active">One</a></li>
<li><a href="#fragment-2">Two</a></li>
<li><a href="#fragment-3">Three</a></li>
</ul>
Expand Down