Restore and warn on arity of jQuery.easing functions #139
Conversation
Watches only `src/*.js` & `test/*.js`
|
By analyzing the blame information on this pull request, we identified @dmethvin, @mgol and @jzaefferer to be potential reviewers |
| @@ -0,0 +1,18 @@ | |||
| var old = jQuery.Tween.prototype.run; | |||
There was a problem hiding this comment.
It would be good to use a more unique name like oldRun here. If another module accidentally declared old it should be found by JSHint but it might be confusing to figure it out.
There was a problem hiding this comment.
Hm, for some reason i thought modules are incapsulated with iffy
|
|
||
| ### JQMIGRATE: jQuery.fn.live() is deprecated; jQuery.fn.die() is deprecated | ||
|
|
||
| **Cause:** The `.live()` and `.die()` methods were deprecated in 1.7 due to their [performance and usability drawbacks](http://api.jquery.com/live), and are no longer supported. |
There was a problem hiding this comment.
I hope those whitespace removal are okay, my editor does it by default
|
@dmethvin done |
Uses Function#bind, so it has obvious downside, but it seems acceptable for migrate plugin Fixes jquery#111
| @@ -1,43 +1,44 @@ | |||
| { | |||
| "name": "jquery-migrate", | |||
There was a problem hiding this comment.
Spacing changed by the npm --save-dev command, now it correlates with .editorconfig value
There was a problem hiding this comment.
Yeah no problem there, I am surprised that indentation survived for so long. 😄
It doesn't do what you expected it to do See npm/npm#10074 for more info
|
|
||
| ### JQMIGRATE: Additional params for 'jQuery.easing' functions are not documented and redundant | ||
|
|
||
| **Cause**: Additional params for 'jQuery.easing' methods were never documented and redundant, same behaviour could be easily achived by other means. |
There was a problem hiding this comment.
Oh, chaps from the old country will be so disappointed :)
|
LGTM after the spelling fix. |
|
Btw, achived is a typo as well. |
|
Fixed, thank you |
Uses
Function#bind, so it has obvious downside, but it seems acceptable for migrate plugin./cc @gnarf