Attributes: Warn and fill .toggleClass( boolean ) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: Need to update the upgrade guide, it currently says only the no-args form is deprecated but the single-boolean form is deprecated as well. |
| e.addClass( "testD testE" ); | ||
| assert.ok( e.is( ".testD.testE" ), "Assert class present" ); | ||
| e.toggleClass(); | ||
| assert.ok( !e.is( ".testD.testE" ), "Assert class not present" ); |
There was a problem hiding this comment.
Maybe test that e has none of those classes and not that it just doesn't have both at the same time?
There was a problem hiding this comment.
These tests were copied from core pretty much as-is so I hesitate to add more assertions. Whatever it was doing before was lightly documented and we're deprecating it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175