-
Notifications
You must be signed in to change notification settings - Fork 476
Build: add UMD support #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
Awesome, thanks! |
We may want to add |
@dmethvin yeah, that makes sense! Do you think these change should be applied to |
Yes, I can cherry pick it into that branch as well and do new releases for both. |
OK, should I squash those 2 commits before merge? |
I can squash them when I land it. |
Why is |
I remember thinking about this at the time, the issue with peerDependencies is that npm3 requires you to install them manually and I didn't wan't to do that. Maybe there is another way out? Perhaps just devDependency, since the Migrate code itself dynamically checks that there is a jQuery core loaded. |
There's no way around that. The purpose of |
This PR implements UMD support as discussed in #98 regarding "Support CJS internally".