Skip to content

Build: Followup to #206, fix jQuery dependency #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmethvin
Copy link
Member

Is this along the lines of what you were thinking in #206 (comment) @mgol? Since we are pulling the actual dependencies from the CDN for testing, we don't actually use these npm-installed copies.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.5% when pulling ec6b349 on dmethvin:206-fix-deps into f7c8363 on jquery:master.

"dependencies": {
"jquery": "3.0.0"
"peerDependencies": {
"jquery": ">3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably >= right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, and I wonder if I should also limit to <4.0.0 since we'll plan on a new round of removals then?

@mgol
Copy link
Member

mgol commented Sep 28, 2016

Yep, I was thinking about specifying ">=3 <4". That should be enough.

Michał Gołębiowski

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.5% when pulling 2ae55f8 on dmethvin:206-fix-deps into f7c8363 on jquery:master.

@dmethvin dmethvin closed this in 5acafbc Sep 30, 2016
@dmethvin dmethvin deleted the 206-fix-deps branch September 12, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants