Traces: commas replaced by semi-colons #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardization of the trace text shape to facilitate textual search into https://github.com/jquery/jquery-migrate/blob/1.x-stable/warnings.md I arbitrary chose the semi-column as a sentence separator. This is not important, the goal is to be homogeneous between the sources and the documentation, because there is at least one inconsistency with "JQMIGRATE: jQuery.parseJSON is deprecated; use JSON.parse", that I want to fix.
|
@LaurentBarbareau, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dmethvin, @mgol and @markelog to be potential reviewers |
|
It's semi-colons, not semi-columns. :-) I agree we should be consistent; which style do you prefer, @dmethvin? |
|
This change with semicolons is fine with me. @LaurentBarbareau can you also check that this is consistent with the |
|
Ok, thank you. I've done the modifications into warnings.md #223 but some commas still need to be replaced by semi-colons into that file and the corresponding sources ;) |
|
LGTM! Thanks @LaurentBarbareau we'll land this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardization of the trace text shape to facilitate textual search into https://github.com/jquery/jquery-migrate/blob/1.x-stable/warnings.md
I arbitrary chose the semi-colon as a sentence separator. This is not important, the goal is to be homogeneous between the sources and the documentation, because there is at least one inconsistency with "JQMIGRATE: jQuery.parseJSON is deprecated; use JSON.parse", that I want to fix too.