Skip to content

Traces: commas replaced by semi-colons #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Traces: commas replaced by semi-colons #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc0f4e
Traces: commas replaced by semi-columns
LaurentBarbareau Aug 29, 2016
1073914
Update warnings.md
LaurentBarbareau Aug 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ for ( findProp in oldFind ) {

// The number of elements contained in the matched element set
jQuery.fn.size = function() {
migrateWarn( "jQuery.fn.size() is deprecated and removed, use the .length property" );
migrateWarn( "jQuery.fn.size() is deprecated and removed; use the .length property" );
return this.length;
};

Expand Down Expand Up @@ -90,10 +90,10 @@ jQuery.isNumeric = function( val ) {
};

migrateWarnFunc( jQuery, "unique", jQuery.uniqueSort,
"jQuery.unique is deprecated, use jQuery.uniqueSort" );
"jQuery.unique is deprecated; use jQuery.uniqueSort" );

// Now jQuery.expr.pseudos is the standard incantation
migrateWarnProp( jQuery.expr, "filters", jQuery.expr.pseudos,
"jQuery.expr.filters is deprecated, use jQuery.expr.pseudos" );
"jQuery.expr.filters is deprecated; use jQuery.expr.pseudos" );
migrateWarnProp( jQuery.expr, ":", jQuery.expr.pseudos,
"jQuery.expr[':'] is deprecated, use jQuery.expr.pseudos" );
"jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos" );
6 changes: 3 additions & 3 deletions warnings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ This is _not_ a warning, but a console log message the plugin shows when it firs

**Solution**: Replace any use of `.andSelf()` with `.addBack()`.

### JQMIGRATE: jQuery.fn.size() is deprecated and removed, use the .length property
### JQMIGRATE: jQuery.fn.size() is deprecated and removed; use the .length property

**Cause**: The `.size()` method returns the number of elements in the current jQuery object, but duplicates the more-efficient `.length` property which provides the same functionality. As of jQuery 1.9 the `.length` property is the preferred way to retrieve this value. jQuery 3.0 no longer contains the `.size()` method.

Expand Down Expand Up @@ -173,8 +173,8 @@ See jQuery-ui [commit](https://github.com/jquery/jquery-ui/commit/c0093b599fcd58

**Solution**: Replace all uses of `jQuery.unique` with `jQuery.uniqueSort` which is the same function with a better name.

### JQMIGRATE: jQuery.expr[':'] is deprecated, use jQuery.expr.pseudos
### JQMIGRATE: jQuery.expr.filters is deprecated, use jQuery.expr.pseudos
### JQMIGRATE: jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos
### JQMIGRATE: jQuery.expr.filters is deprecated; use jQuery.expr.pseudos

**Cause:** The standard way to add new custom selectors through jQuery is `jQuery.expr.pseudos`. These two other aliases are deprecated, although they still work as of jQuery 3.0.

Expand Down