CSS: Don't warn for number values when prop in jQuery.cssNumber #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on numerical values for most CSS properties having `"px"` auto-appended when set via `.css( prop, value )` is deprecated. So far, Migrate was warning for number values for all CSS properties with the exception of the ones to which jQuery 4.x will still auto-append `"px"`. However, if the used jQuery version contains the property as a key in `jQuery.cssNumber`, it will already skip the `"px"` auto-appending behavior, exactly as jQuery 4.x will. This commit removes a warning in such cases. This change will help jQuery UI from not triggering Migrate warnings.
dmethvin
approved these changes
May 12, 2020
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 18, 2020
The way warning agains number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 18, 2020
The way warning against number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
2 tasks
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Jul 20, 2020
The way warning against number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Closes gh-4753 Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Jul 29, 2020
The warning has been updated in code in jquerygh-348 but not in warnings.md. Ref jquerygh-348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on numerical values for most CSS properties having
"px"auto-appendedwhen set via
.css( prop, value )is deprecated. So far, Migrate was warningfor number values for all CSS properties with the exception of the ones to which
jQuery 4.x will still auto-append
"px". However, if the used jQuery versioncontains the property as a key in
jQuery.cssNumber, it will already skipthe
"px"auto-appending behavior, exactly as jQuery 4.x will. This commitremoves a warning in such cases.
This change will help jQuery UI from not triggering Migrate warnings.