CSS: Warn and fill .css(name, Number) #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dmethvin The first commit is yours, my modifications in the second one. |
mgol
commented
Apr 10, 2020
mgol
commented
Apr 10, 2020
mgol
commented
Apr 10, 2020
mgol
commented
Apr 10, 2020
dmethvin
approved these changes
Apr 10, 2020
Member
dmethvin
left a comment
There was a problem hiding this comment.
Good to merge after removing the warning.
Member
Author
|
@dmethvin I removed warning on |
Member
Author
|
@dmethvin This is a new warning so we probably need a new minor release, not a patch one. So the next one would be |
Member
|
Agreed, I've renamed the next milestone. |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 18, 2020
The way warning agains number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 18, 2020
The way warning against number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
2 tasks
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Jul 20, 2020
The way warning against number values in `.css()` setters was done in jquery/jquery-migrate#337 and later refined in jquery/jquery-migrate#348 there's no need to send px-ed strings for `top` & `left` as they already don't get the "px" suffix. This reverts commit 57038fa. Closes gh-4753 Ref jquery/jquery-migrate/pull/337 Ref jquery/jquery-migrate/pull/348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296