CSS: Don't warn against .css( "z-index", numberValue ) in jQuery >=4
#439
Conversation
When used against jQuery Git (future jQuery 4), there were warnings when `.css()` was used against `z-index` with a number value. This didn't make sense as `z-index` never had `px` auto-appended. Commit d25ecd6 was supposed to solve a similar problem but it only worked fine for `3.x`. To make the warning not show up when used with jQuery >=4 we need to fill in `jQuery.cssNumber` with the latest version from jQuery 3.x so that the same properties are allowed to have number values used with `.css()`. Fixes jquerygh-438
| @@ -62,7 +62,7 @@ QUnit.test( "jQuery.css with arrays", function( assert ) { | |||
|
|
|||
| QUnit.test( "jQuery.css with numbers", function( assert ) { | |||
| var jQuery3OrOlder = compareVersions( jQuery.fn.jquery, "4.0.0" ) < 0, | |||
| whitelist = [ | |||
| allowlist = [ | |||
| if ( !jQuery.cssNumber ) { | ||
| jQuery.cssNumber = {}; | ||
| jQuery.cssNumber = { |
There was a problem hiding this comment.
This is not 100% necessary as Core doesn't need this object in 4.x; we could as well just enumerate allowlisted properties in Migrate. However, by doing it via jQuery.cssNumber we have the same Migrate code path for all jQuery versions and it's easier to copy the object from the 3.x-stable Core branch if there are any changes.
There was a problem hiding this comment.
Yeah it seems easier to just copy over the list. It's an exposed object so who knows, maybe some software out there is looking at it and not just setting properties.
|
Landed. I don't think we need to release at the moment as it only affects jQuery Git at the moment; by the time we release jQuery 4.0 we're likely to have another Migrate release for different reasons anyway. |
When used against jQuery Git (future jQuery 4), there were warnings when
.css()was used againstz-indexwith a number value. This didn't make senseas
z-indexnever hadpxauto-appended. Commitd25ecd6 was supposed to solve a similar problem
but it only worked fine for
3.x.To make the warning not show up when used with jQuery >=4 we need to fill in
jQuery.cssNumberwith the latest version from jQuery 3.x so that the sameproperties are allowed to have number values used with
.css().With this PR, jQuery UI with jQuery git & jQuery Migrate shows no Migrate
warnings, similarly to what's already the case when jQuery 3.x-git is used.
Fixes gh-438