-
Notifications
You must be signed in to change notification settings - Fork 476
CSS: Don't warn against .css( "z-index", numberValue )
in jQuery >=4
#439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,7 +62,7 @@ QUnit.test( "jQuery.css with arrays", function( assert ) { | |
|
||
QUnit.test( "jQuery.css with numbers", function( assert ) { | ||
var jQuery3OrOlder = compareVersions( jQuery.fn.jquery, "4.0.0" ) < 0, | ||
whitelist = [ | ||
allowlist = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
"margin", | ||
"marginTop", | ||
"marginRight", | ||
|
@@ -95,7 +95,7 @@ QUnit.test( "jQuery.css with numbers", function( assert ) { | |
"borderLeftWidth" | ||
]; | ||
|
||
assert.expect( jQuery3OrOlder ? 7 : 6 ); | ||
assert.expect( jQuery3OrOlder ? 8 : 7 ); | ||
|
||
function kebabCase( string ) { | ||
return string.replace( /[A-Z]/g, function( match ) { | ||
|
@@ -127,8 +127,8 @@ QUnit.test( "jQuery.css with numbers", function( assert ) { | |
} ); | ||
} ); | ||
|
||
expectNoWarning( assert, "Number value (whitelisted props)", function() { | ||
whitelist.forEach( function( prop ) { | ||
expectNoWarning( assert, "Number value (allowlisted props)", function() { | ||
allowlist.forEach( function( prop ) { | ||
jQuery( "<div />" ).css( prop, 1 ); | ||
jQuery( "<div />" ).css( kebabCase( prop ), 1 ); | ||
} ); | ||
|
@@ -147,6 +147,14 @@ QUnit.test( "jQuery.css with numbers", function( assert ) { | |
} | ||
} ); | ||
|
||
// z-index is tested explicitly as raw jQuery 4.0 will not have `jQuery.cssNumber` | ||
// so iterating over it won't find anything and we'd like to ensure number values | ||
// are not warned against for safe CSS props like z-index (gh-438). | ||
expectNoWarning( assert, "z-index", function() { | ||
jQuery( "<div />" ).css( "z-index", 1 ); | ||
jQuery( "<div />" ).css( kebabCase( "zIndex" ), 1 ); | ||
} ); | ||
|
||
} ); | ||
|
||
QUnit.test( "jQuery.cssNumber", function( assert ) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man we can never win. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not 100% necessary as Core doesn't need this object in 4.x; we could as well just enumerate allowlisted properties in Migrate. However, by doing it via
jQuery.cssNumber
we have the same Migrate code path for all jQuery versions and it's easier to copy the object from the3.x-stable
Core branch if there are any changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it seems easier to just copy over the list. It's an exposed object so who knows, maybe some software out there is looking at it and not just setting properties.