Closed
Conversation
Author
|
Please note my fix only supports vertical scrolling. ie8 & less doesn't seem to register the xaxis scrolling event. See: http://stackoverflow.com/questions/10821985/detecting-mousewheel-on-the-x-axis-left-and-right-with-javascript |
|
try http://www.browserstack.com/ for testing most Browsers |
Contributor
|
The idea was that if the browser didn't support reporting the event on a different axis, then it wouldn't update those values. Seems as though I should go back to the previous logic of always setting deltaY even if the browser doesn't report a deltaY. |
Contributor
|
Closing in favor of #74. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic support for deltaY and deltaX values for ie8, bringing it inline with ie9. Tested on Mac with Browsers: Chrome 27, Firefox 21, Safari 6 & a Windows 7 VM running ie8, ie9.