Skip to content

autocomplete: do not set value on multi-line input. #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Yermo
Copy link
Contributor

@Yermo Yermo commented Jan 25, 2014

Fixes issue where contenteditable text was getting overwritten when
wrapping past the bottom or top of the autocomplete menu.

Fixes #9771

Fixes issue where contenteditable text was getting overwritten when
wrapping past the bottom or top of the autocomplete menu.

Fixes #9771
@scottgonzalez
Copy link
Member

Please review the changes I made in scottgonzalez/jquery-ui@354d105 as I'd like to squash those into your commit when landing. I'll also be moving the test to autocomplete_core.js since this test isn't about the functionality of an event.

@Yermo
Copy link
Contributor Author

Yermo commented Jan 28, 2014

Yes. This looks better. Moving the test makes sense. I wasn't sure where it should go.

@scottgonzalez
Copy link
Member

Thanks :-)

@Yermo
Copy link
Contributor Author

Yermo commented Jan 28, 2014

My pleasure. Fixing this bug is a huge help for me. I appreciate you
guys being willing to include my patch (and improve it).

I guess I get to go brag about having contributed an "if" statement to
the jquery-ui project. ;)

-- Yermo

On 01/28/2014 12:39 PM, Scott González wrote:

Thanks :-)


Reply to this email directly or view it on GitHub
#1184 (comment).


Yermo Lamers Software Guy, Motorcyclist and Reluctant Writer

            http://miles-by-motorcycle.com

A social network for the lucky few who travel by motorcycle

and those who care about them.

@scottgonzalez
Copy link
Member

Your first commit to a project could be smaller... nodejs/node-v0.x-archive@6eff893 ;-)

@Yermo
Copy link
Contributor Author

Yermo commented Jan 28, 2014

LAUGH!

Challenge accepted! ;)

-- Yermo

On 01/28/2014 12:45 PM, Scott González wrote:

Your first commit to a project could be smaller... nodejs/node-v0.x-archive@6eff893
nodejs/node-v0.x-archive@6eff893
;-)


Reply to this email directly or view it on GitHub
#1184 (comment).


Yermo Lamers Software Guy, Motorcyclist and Reluctant Writer

            http://miles-by-motorcycle.com

A social network for the lucky few who travel by motorcycle

and those who care about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants