Skip to content

Slider: Suppress the click events of disabled handles #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tjvantoll
Copy link
Member

Fixes #9890

@scottgonzalez
Copy link
Member

I'd prefer to look into http://bugs.jqueryui.com/ticket/7163 before making this change.

@jcarlson
Copy link

jcarlson commented Mar 5, 2014

Good grief. That PR came in faster than I could at least submit my failing spec to illustrate the issue! Thanks!

@jcarlson
Copy link

jcarlson commented Mar 5, 2014

Re: http://bugs.jqueryui.com/ticket/7163, I'd love to see the removal of 'href' attributes from things that don't have URLs... the '#' values are not very semantically useful. In the meantime, this PR resolves the regression without preventing a change to tabindex="0" in the future, so I would vote to move forward with this change.

@tjvantoll
Copy link
Member Author

Well really, there's no reason the handles should even be <a> elements that I can think of. Handles using <span tabindex="0"> elements seem to work just fine in IE 8 - 11, Firefox, Chrome, and Safari. I'll do more thorough testing tomorrow, but I think we can just switch to <span>s and avoid this problem altogether.

@tjvantoll
Copy link
Member Author

Alternative PR: #1207.

@scottgonzalez
Copy link
Member

Let's go with the alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants