Slider: Switch handles from <a href="#"> to <span tabindex="0"> #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in IE 8 - 10, Firefox, Chrome, and Safari and this seems solid to me. |
|
Looks good to me. |
| @@ -149,7 +149,7 @@ return $.widget( "ui.slider", $.ui.mouse, { | |||
| }, | |||
|
|
|||
| _setupEvents: function() { | |||
| var elements = this.handles.add( this.range ).filter( "a" ); | |||
| var elements = this.handles.add( this.range ).filter( ".ui-slider-handle" ); | |||
There was a problem hiding this comment.
While we're here, let's just remove the elements variable and use this.handles directly. This code became obsolete a long time ago and now ranges are always divs.
|
I removed the |
| this._on( elements, this._handleEvents ); | ||
| this._hoverable( elements ); | ||
| this._focusable( elements ); | ||
| this.handles.add( this.range ).filter( ".ui-slider-handle" ); |
There was a problem hiding this comment.
This line just needs to be dropped.
|
Looks good to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9890