Build: Add manifest entry for selectmenu #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good. |
Member
Author
|
There's something wrong with the generated dependencies field. It looks like this: "dependencies": {
"jquery": ">=1.6 <1.11",
"ui.core": "1.11.0-pre",
"ui.widget": "1.11.0-pre",
"ui.menu": "1.11.0-pre",
"ui.position": "1.11.0-pre",
"ui.button": "1.11.0-pre",
"ui.draggable": "1.11.0-pre",
"ui.resizable": "1.11.0-pre"
},This shouldn't include draggable nor resizable. This also happens for others, e.g. menu. And menu doesn't depend on button. Looking into that... |
Member
Author
|
Added a commit that fixes the bad dependencies. I don't like the for-in loop, but couldn't think of something more convenient for clone the |
Member
Author
|
@scottgonzalez can you review the second commit? |
Member
|
Looks good. |
Clone bower dependencies instead of reusing and modifying the same object multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.