-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Datepicker and Calendar: WIP #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
177 commits
Select commit
Hold shift + click to select a range
d3216b3
Datepicker: Initial commit of widget rewrite work from old branch. Hi…
tjvantoll b850573
Datepicker: Get datepicker's test suite to at least run. It fails hor…
tjvantoll bf19f75
Datepicker: Updating/fixing the animation demo.
tjvantoll 632aa2b
Datepicker: Fix the build. Exclude broken datepicker units from runni…
jzaefferer 7a8f351
Datepicker: Fix dateFormat demo by adding a dateFormat option and pas…
jzaefferer c8217f5
Datepicker: Update all demos to include necessary dependencies. Doesn…
jzaefferer f0b49f6
Datepicker: Improve animations demo, make slideUp actually work
jzaefferer 907d370
Datepicker: Fix localization demo
jzaefferer abaeedc
Datepicker: Update alt-field demo - remove the options and use Global…
jzaefferer cb3f565
Datepicker: Fix dependencies on buttonbar demo
jzaefferer 7adf5bf
Datepicker: Fix the eachDay option (until we have a better design), u…
jzaefferer 88d3c69
Datepicker: Update icon-trigger demo, build a custom trigger. Prevent…
jzaefferer b59d4de
Datepicker: Only apply the ui-state-focus class name to one cell.
tjvantoll 45d64ea
Datepicker: Fixing widget() method test and minor coding standard cha…
tjvantoll 41add14
Datepicker: Updating first batch of structure tests to new APIs and s…
tjvantoll ebeb23e
Datepicker: Fixing and/or commenting out remaning multi month datepic…
tjvantoll 5baa227
Datepicker: Fixing or commenting out remaining structure tests.
tjvantoll c8a0eed
Datepicker: Cleaning up and commenting out custom structure tests as …
tjvantoll 00debdf
Datepicker: Coding standards and new APIs for keyboard handling tests.
tjvantoll fb79842
Datepicker: Coding standards and new APIs for mouse core tests.
tjvantoll f79cc9e
Datepicker: Commenting out event tests with TODOs for now.
tjvantoll 97ad9ca
Datepicker: Adding boilerplate for events in new API.
tjvantoll 45c126d
Datepicker: Updating tests for the destroy() method.
tjvantoll c68d3e5
Datepicker: Updating enable()/disable() tests.
tjvantoll 6782140
Datepicker: Boilerplate for other method tests.
tjvantoll 0f6d4e2
Datepicker: Commenting out the options tests for now as they are almo…
tjvantoll b986309
Merge branch 'master' into datepicker
tjvantoll d32a482
Datepicker: Saner id attribute values for the test suite.
tjvantoll 1074fdd
Datepicker: Support changing the appendTo option after init.
tjvantoll 601bf92
Datepicker: Boilerplate for tests for additional implemented options.
tjvantoll 488665a
Datepicker: Various changes for the showWeek option.
tjvantoll 25ac260
Datepicker: Support position option changes after init. Added positio…
tjvantoll 6da407b
Datepicker: Position tests should create a new <input>.
tjvantoll 6e36670
Datepicker: Support changing eachDay after initialization. Add tests …
tjvantoll dfad85f
Datepicker: Allow dateFormat to be changed after init. Add dateFormat…
tjvantoll f83adf8
Datepicker: Adding test to ensure the <input>'s value is preselected …
tjvantoll 83646f9
Datepicker: Implementing a value() method.
tjvantoll b668db2
Datepicker: Implement a valueAsDate() method.
tjvantoll 560e704
Datepicker: Support destroying inline datepickers.
tjvantoll 44eb843
Datepicker: Add tests for the value() and valueAsDate() methods and i…
tjvantoll 3333c70
Datepicker: Remove unnecessary code now that destroying inline picker…
tjvantoll fd94740
Datepicker: Enter keypresses on the <input> should select the current…
tjvantoll a089c49
Datepicker: Enable enter with existing value test. Coding standards c…
tjvantoll 845814c
Datepicker: Restore handling of Control+Home and Control+End on the <…
tjvantoll e14f8e6
Datepicker: Updating escape key tests to new APIs.
tjvantoll fdaac17
Datepicker: First batch of tests for arrow key handling.
tjvantoll febd2b2
Datepicker: Use Globalize 1.0.0
rxaviers db78dd5
Datepicker: Use Globalize 1.0.0
rxaviers e4a3e82
Datepicker: Test for up and down arrow keys
tjvantoll 677601c
Datepicker: Tests for Page Up and Page Down keys
tjvantoll 7e79a71
Datepicker: Tests for moving years with Page Up and Page Down
tjvantoll 6c2a806
Datepicker: Use explicit dates in tests.
tjvantoll 0c40d2a
Datepicker: Port tests for keyboard handling with short months & leap…
tjvantoll 010a131
Datepicker: Re-adding mouse tests.
tjvantoll 5da4880
Datepicker: Adding an isValid() method.
tjvantoll b2018c4
Datepicker: Handle for invalid values in value() and valueAsDate()
tjvantoll 98c8556
Datepicker: Update the picker as the user types valid dates
tjvantoll 0cd4989
Date: Updating test suite to coding standards.
tjvantoll dee3879
Date: Make $.date() a constructor function. Move methods to prototype.
tjvantoll 8b2e13c
Merge branch 'master' into datepicker
tjvantoll e86cd81
Merge branch 'master' into datepicker
fnagel 4d65dae
Datepicker: fix jshint and htmllint issues, code style
fnagel 036190e
Datepicker: rename select method to _select
fnagel 6ee2cd5
Datepicker: fix and simplify icon trigger demo
fnagel 7175e0d
Datepicker: use short instead of abbreviated format for table header
fnagel 2914766
Datepicker: remove unneeded comma
fnagel c3a2b1b
Datepicker: remove unneeded default setting of option dateFormat
fnagel 3736808
Datepicker: fix populate alternate field demo
fnagel 8d9f5db
Datepicker: adjust date.js day name unit test to short name change
fnagel cd96b4c
Datepicker: restore old icon trigger demo behavior
fnagel 49728a9
Datepicker: Introduce value option
fnagel d6c8e5d
Calendar: Add calendar widget
fnagel bb275b7
Calendar: remove unneeded translation files
fnagel 44baada
Calendar: Rename $.date selected method
fnagel d11e35b
Calendar: remove datepicker functionality, options and methods
fnagel 7aac60a
Calendar: Fix focus highlighting when month is changed
fnagel 485825d
Calendar: Make use of uniqueId method
fnagel dad7a63
Calendar: Add _isValid method
fnagel 9191785
Datepicker: $.date.selected() should return the actual date object
fnagel 8acfca5
Datepicker: Remove calendar functionality, options and methods
fnagel aa1aea1
Calendar: Fix AMD dependencies
fnagel 504ab73
Calendar: Add min and max option
fnagel ada1afb
Calendar: Remove unneeded demo files
fnagel 8f5e4c8
Datepicker: Add min and max option
fnagel 83ff362
Datepicker: Remove select callback reference
fnagel 088bcca
Calendar: Remove select callback reference
fnagel c1e4beb
Calendar: Fix min / max option incl. refresh after setting option
fnagel 9709140
Calendar: Fix multiple calendar styles
fnagel 2d380e8
Datepicker: Fix date range demo
fnagel 8feabf1
Datepicker: Remove unneeded inline demo file
fnagel 6083a01
Datepicker: Read and write min / max attributes
fnagel 7cabbef
Calendar: Add missing AMD dependency todo comment
fnagel 43b448e
Datepicker: Read and write min / max attributes (follow-up)
fnagel fb774c8
Datepicker tests: Add Calendar widget dependency to unit tests
fnagel 21c101d
Datepicker tests: Remove inline Datepicker unit tests
fnagel 87acbb6
Datepicker: Simplify calendar generation
fnagel 706b4fe
Calendar: Simplify calendar generation
fnagel e593e15
Datepicker: Code clean up for events
fnagel 56d662e
Datepicker: Fix uni test
fnagel f703b9b
Datepicker: remove guard clause to check if element is an input
fnagel 936f88b
Datepicker: Remove unwanted keyboard shortcut
fnagel f339e25
Datepicker: remove unneeded translation files
fnagel ae3594d
Datepicker: Make sure calendar sets new option value before datepicker
fnagel c9e0b7b
Datepicker: Make use of _getCreateOptions for min and max options
fnagel 4122838
Datepicker: Use correct format for reading min and max options.
fnagel f37357f
Datepicker: Simplify usage of calendar options and avoid duplications
fnagel 5a6b6ff
Datepicker: Fix input keyboard handling
fnagel 6a50410
Datepicker: Update value from input on refresh
fnagel 4a0cdde
Datepicker: Simplify value method
fnagel 7bf578b
Datepicker: Fix dateFormat option setting incl. date-formats demo.
fnagel 42e8950
Datepicker tests: Adjust methods unit tests according to specs
fnagel 26a4ed6
Datepicker: Fix some core unit tests, remove unneeded tests
fnagel f375c7d
Datepicker tests: Remove unneeded options unit tests, add todo comments
fnagel 9e26110
Merge branch 'master' into datepicker
fnagel 3c2917e
Datepicker tests: Rewrite unit test for beforeOpen event (#7602)
fnagel c4ff049
Datepicker tests: Re-enable some min / max option unit tests
fnagel 1131bce
Datepicker tests: Adjust min / max option unit tests to specification
fnagel 66ba886
Datepicker tests: clean up method tests
fnagel 0d3cd04
Calendar: Add version property
fnagel 8531690
Datepicker: Add version property
fnagel f338f59
Datepicker tests: Add common unit tests
fnagel f00e733
Datepicker: code style
fnagel fe57299
Calendar: code style
fnagel dcbac00
Datepicker tests: Add open and close unit tests
fnagel 95a33b5
Datepicker tests: Remove unneeded disabled / enabled options
fnagel 3daa9a7
Datepicker tests: Rewrite setDate tests as valueAsDate method tests
fnagel 8cf0e8f
Calendar: Make it possible to set min / max option to null
fnagel a8189d9
Datepicker: Improve document click event
fnagel 91dfe6e
Calendar: Fix broken day table cell attributes
fnagel 2aacbb9
Datepicker tests: Rewrite event unit tests
fnagel 8bf7263
Datepicker tests: Code style improvements, add todo comment for ARIA
fnagel 32eb9ac
Datepicker tests: Fix calendar keyboard control tests
fnagel 550a0a1
Datepicker tests: Fix mouse core unit tests by adding delay
fnagel b9278de
Datepicker tests: Code style
fnagel f187eb5
Datepicker tests: Unify show / hide options in helper create method
fnagel 9672361
Datepicker: Fix alternate field demo
fnagel 0c3d2f2
Datepicker: Fix demos after widget split
fnagel 557dfbe
Calendar: Fix multiple calendar styles (follow-up)
fnagel 0b8ad82
Calendar: Fix German localization
fnagel becc812
Datepicker: Sort and clean up demo index
fnagel a4ca299
Datepicker: Improve date formats demo
fnagel 200bfe8
Datepicker: Fix localization demo
fnagel b4d522d
Datepicker tests: Fix method test messages
fnagel ba11bf8
Datepicker: Several minor code improvements
fnagel 138fd3a
Calendar: Fix hover event setting and removing
fnagel 181b1de
Calendar: Improve code style and clean up
fnagel 732424b
Calendar: Focus class is not removed when using arrow keys
fnagel ac0f9da
Datepicker: Remove unwanted CTRL+HOME shortcut
fnagel c0d9e8e
Datepicker: Rename multiple calendars demo to multiple months
fnagel f498918
Datepicker: Remove support for enter key on input
fnagel 772703e
Datepicker: Improve localization handling, fix return indenting
fnagel 5513e14
Calendar: Fix German localization
fnagel 0c6a529
Calendar: Update localization provided by Globalize on refresh
fnagel 0819e58
Datepicker tests: Add basic localization unit tests
fnagel 2b8c4d8
Calendar: Improve comment
fnagel a07e9f9
Calendar: Rename multiple calendars demo to multiple months
fnagel c63073f
Calendar: Sort and clean up demo index
fnagel 66385d4
Calendar: Fix demos after widget split
fnagel 4110db0
Calendar: Add buttons option
fnagel 22e29af
Datepicker: Add buttons option
fnagel 422f798
Datepicker tests: Rework structure unit tests for buttons option
fnagel 764305c
Datepicker: Remove outdated localization tests
fnagel fd88d79
Calendar: Fix wrong class in _createButtons method
fnagel 546565b
Datepicker: Add option unit tests for buttons option
fnagel 37377a5
Datepicker: Fix multiple calendar styles (follow-up)
fnagel 86ca70b
Datepicker: Remove duplicate demos
fnagel ef3a30c
Calendar: Rename multiple calendars demo to multiple months (follow-up)
fnagel b547f3a
Calendar: Remove unneeded image
fnagel 632adc6
Calendar tests: Rewrite core unit tests based on datepicker tests
fnagel c9fdefe
Calendar tests: Add common unit tests
fnagel 923a4b8
Calendar tests: Remove unneeded image
fnagel 98517b3
Calendar tests: Fix title
fnagel 9e8936d
Calendar: Set selected property to null by default
fnagel 2051a8d
Calendar tests: Rewrite method unit tests based on datepicker tests
fnagel 4ce0c3f
Merge branch 'master' into datepicker
fnagel 077e9aa
Calendar: Adjust files to match reorganization of external directory
fnagel 7bb5056
Datepicker: Adjust files to match reorganization of external directory
fnagel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Datepicker: Read and write min / max attributes (follow-up)
- Loading branch information
commit 43b448e0888f1519844fa9821aa0670ab4d7f722
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be moved to
_getCreateOptions, as in spinner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this.options.dateFormat to process the min and max attributes (similar to the processing of the value option). Afaik the needed widget parameters (at least option dateFormat) are not available in the _getCreateOptions method. So this seems not possible or do I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not processing anything right here, you're just getting the attribute values. That's what should move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok but where to (temp) save the retrieved string values? Is it okay to store them in the options in _getCreateOptions and overwrite them in _create after parsing the actual date objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just return the values and they'll be merged into the options. The option values need to be normalized on creation and setting anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.