Datepicker and Calendar: WIP #1260

fnagel · 2014-06-04T17:47:36Z

This was replaced by #1281.

This PR introduces the Calendar widget which is utilized in Datepicker widget. It also includes several improvements and changes as outlined in the wiki: http://wiki.jqueryui.com/w/page/12137778/Datepicker

Included changes and bugfixes:

Introduce value option
Split functionality into Datepicker and Calendar widget
Fix item highlighting when month is changed
Make use of uniqueId method
Improvements for $.date
Add min and max option
Fix some minor style issues for multi calendar support
Fix most demos
Fixed and improved existing datepicker unit tests
Improved localization, added localization unit tests.

…story is on the datepicker-dead branch.

…ribly, but at least it loads with its dependencies.

…ng with phantomjs. Fix various jshint warnings in date_core tests and datepicker src

…sing that through to $.date

…'t mean that they actually work for the most part

…ize to parse and format instead

…se that in other-months demo. Fix handling of extraClasses property, split on space.

… the datepicker from opening with a new cancellable beforeOpen event. Cancel = don't open

This is specifically for multi month pickers. This makes the assumption that the keyboard is always interacting with the first month in a multi month calendar. The next step is to store which grid currently has focus and to base these focus logic off of that.

…nges.

…tandards.

…ker structure tests.

…none of these options are implemented yet.

These tests are commented out for now as they need a means of getting a Date object from the widget and currently there isn't one.

Disabling these tests as well as they utilize the old getDate() and setDate() methods and there is no replacement for these yet.

Moving widget() method test from core.js as it makes more sense in methods.js.

…st all irrelevant now.

Conflicts: Gruntfile.js ui/jquery.ui.datepicker.js

Adding tests for the appendTo option.

fnagel · 2014-06-20T12:39:29Z

@tjvantoll I agree - we should merge this soon to keep the PR usable. I already finished removing duplicated demos and started with the unit tests. This will take some more time as it's an non trivial task and I'm starting a new job next week.

Remove duplicated core unit tests from datepicker tests.

fnagel · 2014-06-27T22:29:34Z

@rxaviers Thanks for your comments. Which seems to be no more available, even when using the anchor links within the GitHub notification emails. We already talked about updating Globalize and I will make sure to add proper dependencies to calendar / datepicker.

rxaviers wrote:

General reminder: external/date.js is NOT an external library. It's not hosted (neither version-controlled) anywhere except in here. So, we may need to either make it an external library or move it inside ui/.

@jzaefferer @scottgonzalez @tjvantoll Any thoughts on this?

jzaefferer · 2014-06-27T22:52:53Z

As I wrote in a wiki comment: Regarding the pseudo-external date.js: I suggest handling it as another source file for now, putting it in the "ui" folder. The unit tests already match that. That would be less misleading then what we have now. And we can still extract it later, if we want to.

rxaviers · 2014-06-27T23:38:08Z

@fnagel, thanks for bringing it back. After I added a couple of comments in here and talked with Scott about it, I realized my comments made more sense to be added into the wiki instead. So, I've deleted them and edited the wiki accordingly.

@jzaefferer, I think your approach is better than the current scenario. So, 👍

tjvantoll · 2014-06-29T01:44:59Z

+1 to putting date.js in the "ui" folder for now.

fnagel · 2014-07-02T14:58:10Z

PR updated: work on unit tests (fix calendar tests and remove duplicates), fix calendar demos, removed duplicated demos, fix some minor issues.

scottgonzalez · 2014-07-02T15:02:10Z

Can you rebase this? It's really hard to see what's actually happening with all the old commits.

fnagel · 2014-07-02T15:06:08Z

We already talked about rebase vs. merge and agreed to merge datepicker branch as a rebase is to much trouble.

The latest commits start at TJs comment from June 19.

We talked about closing this PR as soon as I finish the unit tests split (which should be very soon as all test except the options tests are ready).

jzaefferer · 2014-07-02T15:08:17Z

How about merging master into the datepicker branch, the rebasing this PR on top of it? That should get the non-datepicker commits out of this PR.

Conflicts: demos/calendar/buttonbar.html demos/calendar/dropdown-month-year.html demos/calendar/multiple-months.html demos/datepicker/alt-field.html demos/datepicker/animation.html demos/datepicker/date-formats.html demos/datepicker/date-range.html demos/datepicker/default.html demos/datepicker/icon-trigger.html demos/datepicker/inline.html demos/datepicker/localization.html demos/datepicker/min-max.html demos/datepicker/other-months.html demos/datepicker/show-week.html external/globalize/globalize.culture.de-DE.js external/globalize/globalize.culture.ja-JP.js tests/unit/datepicker/datepicker.html

fnagel · 2014-07-07T19:20:32Z

@scottgonzalez Did you manage to find some time to look at this PR?

scottgonzalez · 2014-07-07T19:22:55Z

I've gotten through all the commits in the original datepicker branch (see https://github.com/scottgonzalez/jquery-ui/tree/datepicker-rebase-cleanup) and I'll likely be able to start on the rebase of this tomorrow morning. I expect to have the rebase done before this week's meeting.

fnagel · 2014-07-07T19:44:28Z

Nice, thanks for the info.

I'm not sure if I will be able to attend the meeting this week as I'll be at a customer site.

scottgonzalez · 2014-07-14T15:24:04Z

Moved to #1281.

tjvantoll and others added 30 commits September 6, 2013 20:45

Datepicker: Initial commit of widget rewrite work from old branch. Hi…

d3216b3

…story is on the datepicker-dead branch.

Datepicker: Get datepicker's test suite to at least run. It fails hor…

b850573

…ribly, but at least it loads with its dependencies.

Datepicker: Updating/fixing the animation demo.

bf19f75

Datepicker: Fix the build. Exclude broken datepicker units from runni…

632aa2b

…ng with phantomjs. Fix various jshint warnings in date_core tests and datepicker src

Datepicker: Fix dateFormat demo by adding a dateFormat option and pas…

7a8f351

…sing that through to $.date

Datepicker: Update all demos to include necessary dependencies. Doesn…

c8217f5

…'t mean that they actually work for the most part

Datepicker: Improve animations demo, make slideUp actually work

f0b49f6

Datepicker: Fix localization demo

907d370

Datepicker: Update alt-field demo - remove the options and use Global…

abaeedc

…ize to parse and format instead

Datepicker: Fix dependencies on buttonbar demo

cb3f565

Datepicker: Fix the eachDay option (until we have a better design), u…

7adf5bf

…se that in other-months demo. Fix handling of extraClasses property, split on space.

Datepicker: Update icon-trigger demo, build a custom trigger. Prevent…

88d3c69

… the datepicker from opening with a new cancellable beforeOpen event. Cancel = don't open

Datepicker: Fixing widget() method test and minor coding standard cha…

45d64ea

…nges.

Datepicker: Updating first batch of structure tests to new APIs and s…

41add14

…tandards.

Datepicker: Fixing and/or commenting out remaning multi month datepic…

ebeb23e

…ker structure tests.

Datepicker: Fixing or commenting out remaining structure tests.

5baa227

Datepicker: Cleaning up and commenting out custom structure tests as …

c8a0eed

…none of these options are implemented yet.

Datepicker: Coding standards and new APIs for keyboard handling tests.

00debdf

These tests are commented out for now as they need a means of getting a Date object from the widget and currently there isn't one.

Datepicker: Coding standards and new APIs for mouse core tests.

fb79842

Disabling these tests as well as they utilize the old getDate() and setDate() methods and there is no replacement for these yet.

Datepicker: Commenting out event tests with TODOs for now.

f79cc9e

Datepicker: Adding boilerplate for events in new API.

97ad9ca

Datepicker: Updating tests for the destroy() method.

45c126d

Datepicker: Updating enable()/disable() tests.

c68d3e5

Datepicker: Boilerplate for other method tests.

6782140

Moving widget() method test from core.js as it makes more sense in methods.js.

Datepicker: Commenting out the options tests for now as they are almo…

0f6d4e2

…st all irrelevant now.

Merge branch 'master' into datepicker

b986309

Conflicts: Gruntfile.js ui/jquery.ui.datepicker.js

Datepicker: Saner id attribute values for the test suite.

d32a482

Datepicker: Support changing the appendTo option after init.

1074fdd

Adding tests for the appendTo option.

Datepicker: Boilerplate for tests for additional implemented options.

601bf92

fnagel added 4 commits June 20, 2014 01:01

Datepicker: Fix multiple calendar styles (follow-up)

37377a5

Datepicker: Remove duplicate demos

86ca70b

Calendar: Rename multiple calendars demo to multiple months (follow-up)

ef3a30c

Calendar: Remove unneeded image

b547f3a

fnagel added 3 commits June 20, 2014 17:54

Calendar tests: Rewrite core unit tests based on datepicker tests

632adc6

Remove duplicated core unit tests from datepicker tests.

Calendar tests: Add common unit tests

c9fdefe

Calendar tests: Remove unneeded image

923a4b8

Calendar tests: Fix title

98517b3

fnagel added 2 commits July 1, 2014 22:43

Calendar: Set selected property to null by default

9e8936d

Calendar tests: Rewrite method unit tests based on datepicker tests

2051a8d

fnagel added 3 commits July 2, 2014 18:53

Calendar: Adjust files to match reorganization of external directory

077e9aa

Datepicker: Adjust files to match reorganization of external directory

7bb5056

scottgonzalez mentioned this pull request Jul 14, 2014

Calendar WIP #1281

Closed

scottgonzalez closed this Jul 14, 2014

fnagel mentioned this pull request Sep 3, 2014

Calendar rebase #1316

Closed

rxaviers mentioned this pull request Sep 4, 2014

Datepicker using Globalize 1.x #1341

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Datepicker and Calendar: WIP #1260

Datepicker and Calendar: WIP #1260

Uh oh!

fnagel commented Jun 4, 2014

Uh oh!

fnagel commented Jun 20, 2014

Uh oh!

fnagel commented Jun 27, 2014

Uh oh!

jzaefferer commented Jun 27, 2014

Uh oh!

rxaviers commented Jun 27, 2014

Uh oh!

tjvantoll commented Jun 29, 2014

Uh oh!

fnagel commented Jul 2, 2014

Uh oh!

scottgonzalez commented Jul 2, 2014

Uh oh!

fnagel commented Jul 2, 2014

Uh oh!

jzaefferer commented Jul 2, 2014

Uh oh!

fnagel commented Jul 7, 2014

Uh oh!

scottgonzalez commented Jul 7, 2014

Uh oh!

fnagel commented Jul 7, 2014

Uh oh!

scottgonzalez commented Jul 14, 2014

Uh oh!

Uh oh!

Datepicker and Calendar: WIP #1260

Datepicker and Calendar: WIP #1260

Uh oh!

Conversation

fnagel commented Jun 4, 2014

Uh oh!

fnagel commented Jun 20, 2014

Uh oh!

fnagel commented Jun 27, 2014

Uh oh!

jzaefferer commented Jun 27, 2014

Uh oh!

rxaviers commented Jun 27, 2014

Uh oh!

tjvantoll commented Jun 29, 2014

Uh oh!

fnagel commented Jul 2, 2014

Uh oh!

scottgonzalez commented Jul 2, 2014

Uh oh!

fnagel commented Jul 2, 2014

Uh oh!

jzaefferer commented Jul 2, 2014

Uh oh!

fnagel commented Jul 7, 2014

Uh oh!

scottgonzalez commented Jul 7, 2014

Uh oh!

fnagel commented Jul 7, 2014

Uh oh!

scottgonzalez commented Jul 14, 2014

Uh oh!

Uh oh!