Skip to content

Manage all external libraries via Bower#1266

Closed
scottgonzalez wants to merge 4 commits into
jquery:masterfrom
scottgonzalez:external
Closed

Manage all external libraries via Bower#1266
scottgonzalez wants to merge 4 commits into
jquery:masterfrom
scottgonzalez:external

Conversation

@scottgonzalez
Copy link
Copy Markdown
Member

@scottgonzalez scottgonzalez commented Jun 10, 2014

No description provided.

@scottgonzalez
Build: Reorganize external directory
438c21f 
Put each external library into its own directory.
Move jquery.js to external.
@scottgonzalez
Test: Get all jQuery versions from Bower
e081784
@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jun 10, 2014

I just remembered that we need to check jqueryui.com to make sure the demo copying properly replaces jquery.js after this change.

@jzaefferer
Copy link
Copy Markdown
Member

jzaefferer commented Jun 10, 2014

I haven't checked every single line change, but after reviewing the bower.json, Gruntfile.js and some demos and tests: Looks good to me.

Need to update datepicker and other active branches after landing this, to apply the same changes.

@jzaefferer jzaefferer mentioned this pull request Jun 16, 2014
Closed
rxaviers
rxaviers reviewed Jun 18, 2014
View reviewed changes
Comment thread Gruntfile.js
Copy link
Copy Markdown
Member

@rxaviers rxaviers Jun 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bowercopy thing is so repetitive. 😖

Why do we worry cherry-picking these files instead of using the plain/raw bower-fetched tree?

Copy link
Copy Markdown
Member

@rxaviers rxaviers Jun 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintenance related... Ideally, when new jquery versions are released, one single place could be updated, eg. bower.json.

Copy link
Copy Markdown
Member Author

@scottgonzalez scottgonzalez Jun 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not going to be possible. Different versions have files in different locations. Also, we want to keep our repos as small as possible.

@rxaviers rxaviers mentioned this pull request Jun 18, 2014
Closed
@rxaviers
Copy link
Copy Markdown
Member

rxaviers commented Jun 18, 2014

Related bower issue: bower/bower#1359

@rxaviers
Copy link
Copy Markdown
Member

rxaviers commented Jun 18, 2014

According to bower/bower#1359, bower doesn't support (and it sounds that it won't) different versions of a package on dependencies vs. devDependencies.

So, we either need to drop jquery on devDependencies and use a different name for it; or use a different approach, eg. timmywil/grunt-bowercopy#19?

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jun 23, 2014

According to bower/bower#1359, bower doesn't support (and it sounds that it won't) different versions of a package on dependencies vs. devDependencies.

This doesn't really matter. We'll just use a different name for the devDependency.

@jzaefferer
Copy link
Copy Markdown
Member

jzaefferer commented Jun 23, 2014

grunt-bowercopy 1.1.0 now has an ignore option. We can use that the ignore the jquery: >1.6 module, while including everything else we need under devDependencies.

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jun 23, 2014

Great. I'll update this PR to handle that.

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jun 24, 2014

This has been updated to address http://bugs.jqueryui.com/ticket/10110.

@jzaefferer
Copy link
Copy Markdown
Member

jzaefferer commented Jun 24, 2014

Looks good. Tested the bowercopy task by deleting the externals/ folder and running the task. Afterwards the only changes were deleted globalize files, which is fine since we don't yet manage those with bower. Can you rebase and merge?

scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Build: Reorganize external directory
6df127a 
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Test: Get all jQuery versions from Bower
19dfa2d 
Ref gh-1266
scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Build: Upgrade to grunt-bowercopy 1.1.0
6603270 
Ref gh-1266
@scottgonzalez scottgonzalez deleted the external branch July 17, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottgonzalez @jzaefferer @rxaviers