Skip to content

Manage all external libraries via Bower #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Manage all external libraries via Bower #1266

wants to merge 4 commits into from

Conversation

scottgonzalez
Copy link
Member

No description provided.

@scottgonzalez
Build: Reorganize external directory
438c21f 
Put each external library into its own directory.
Move jquery.js to external.
@scottgonzalez
Test: Get all jQuery versions from Bower
e081784
@scottgonzalez
Copy link
Member Author

I just remembered that we need to check jqueryui.com to make sure the demo copying properly replaces jquery.js after this change.

@jzaefferer
Copy link
Member

I haven't checked every single line change, but after reviewing the bower.json, Gruntfile.js and some demos and tests: Looks good to me.

Need to update datepicker and other active branches after landing this, to apply the same changes.

@jzaefferer jzaefferer mentioned this pull request Jun 16, 2014
Closed
rxaviers
rxaviers reviewed Jun 18, 2014
View reviewed changes
Gruntfile.js
"jquery-2.0.2/MIT-LICENSE.txt": "jquery-2.0.2/MIT-LICENSE.txt",

"jquery-2.0.3/jquery.js": "jquery-2.0.3/jquery.js",
"jquery-2.0.3/MIT-LICENSE.txt": "jquery-2.0.3/MIT-LICENSE.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bowercopy thing is so repetitive. 😖

Why do we worry cherry-picking these files instead of using the plain/raw bower-fetched tree?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintenance related... Ideally, when new jquery versions are released, one single place could be updated, eg. bower.json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not going to be possible. Different versions have files in different locations. Also, we want to keep our repos as small as possible.

@rxaviers rxaviers mentioned this pull request Jun 18, 2014
Closed
@rxaviers
Copy link
Member

Related bower issue: bower/bower#1359

@rxaviers
Copy link
Member

According to bower/bower#1359, bower doesn't support (and it sounds that it won't) different versions of a package on dependencies vs. devDependencies.

So, we either need to drop jquery on devDependencies and use a different name for it; or use a different approach, eg. timmywil/grunt-bowercopy#19?

@scottgonzalez
Copy link
Member Author

According to bower/bower#1359, bower doesn't support (and it sounds that it won't) different versions of a package on dependencies vs. devDependencies.

This doesn't really matter. We'll just use a different name for the devDependency.

@jzaefferer
Copy link
Member

grunt-bowercopy 1.1.0 now has an ignore option. We can use that the ignore the jquery: >1.6 module, while including everything else we need under devDependencies.

@scottgonzalez
Copy link
Member Author

Great. I'll update this PR to handle that.

@scottgonzalez
Copy link
Member Author

This has been updated to address http://bugs.jqueryui.com/ticket/10110.

@jzaefferer
Copy link
Member

Looks good. Tested the bowercopy task by deleting the externals/ folder and running the task. Afterwards the only changes were deleted globalize files, which is fine since we don't yet manage those with bower. Can you rebase and merge?

scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Build: Reorganize external directory
6df127a 
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Test: Get all jQuery versions from Bower
19dfa2d 
Ref gh-1266
scottgonzalez added a commit that referenced this pull request Jun 25, 2014
@scottgonzalez
Build: Upgrade to grunt-bowercopy 1.1.0
6603270 
Ref gh-1266
@scottgonzalez scottgonzalez deleted the external branch July 17, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottgonzalez @jzaefferer @rxaviers