Build: Specify jQuery version as >=1.6, do custom install for this repo #1271
Conversation
| }, | ||
| "devDependencies": { | ||
| "jquery": ">=1.6 <1.11", |
There was a problem hiding this comment.
It seems like we should either declare a specific version here or just go with "<2".
On a related note, maybe I don't know what I'm doing, but when I update this to "jquery": ">=1.6 < 1.12", and run grunt bower on this branch, nothing happens. It seems like I should get 1.11.1.
There was a problem hiding this comment.
I'm fine with changing this version. I'm okay with "<2", but I don't want to mix the jQuery update with this change.
Regarding the other problem, I've added a comment about that in the Gruntfile, where the path has to change. I also reported the poor error handling.
The new bowerinstall task installs the jQuery version as specified in devDependencies, while the dependencies field just specifies the minimal version required. Fixes #10110 Closes gh-1271
| @@ -245,5 +248,6 @@ grunt.registerTask( "lint", [ "asciilint", "jshint", "jscs", "csslint", "htmllin | |||
| grunt.registerTask( "test", [ "qunit" ]); | |||
| grunt.registerTask( "sizer", [ "concat:ui", "uglify:main", "compare_size:all" ]); | |||
| grunt.registerTask( "sizer_all", [ "concat:ui", "uglify", "compare_size" ]); | |||
| grunt.registerTask( "bower", [ "bowerinstall", "bowercopy" ]); | |||
There was a problem hiding this comment.
I've removed the separate install command I had earlier, since the bower behaviour apparently is here to stay, always installing project dependencies even when a specific endpoint is specified.
|
If this is okay now, I could add a second commit to change the version in devDependencies to "<2" and include the update to jQuery 1.11.1. |
|
This looks good to me and I like making the Core update in a separate commit. |
|
Added a separate commit with the jQuery version update. To make sure we don't get regressions from TestSwarm after merging to master I've created a temporary Jenkins jobs. The result is the same as the last run on master, those four selectmenu tests still fail, everything else is green. @tjvantoll can you take another look? |
|
This branch looks good, and I still have fixing those tests on my list. |
|
@timmywil could you take a look at this? |
|
Update: After some discussion in timmywil/grunt-bowercopy#19, it looks like @timmywil will add an |
| }, | ||
| "devDependencies": { | ||
| "jquery": "<2", |
There was a problem hiding this comment.
We actually want an explicit version here, not a range. We want to manually upgrade as new versions come out so we can make sure we fix any potential problems before switching to the new version.
That would be wrong. We don't support jQuery <1.6. |
|
I think the simplest solution is to just throw the unused jQuery file into an ignored directory or add the file itself to |
|
We can copy the unused file to |
The new bowerinstall task installs the jQuery version as specified in
devDependencies, while the dependencies field just specifies the minimal
version required.
Fixes #10110
Probably a bad idea to work on this before #1266 lands, but then I didn't change much in
Gruntfile.js.