All: Drop support for IE7 #1365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9838
|
I would remove the test in dialog_methods.js. Either that or change the description to something generic, like “Ensure form elements don't reset when opening a dialog (see #6137)”. Other than that this looks good. |
scottgonzalez
added a commit
that referenced
this pull request
Nov 7, 2014
Fixes #9838 Closes gh-1365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9838
I left datepicker alone to try to avoid any potential conflicts with the rewrite. There's another reference to IE7 in a test, but I think it's ok to leave.