Skip to content

All: Drop support for IE7 #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

All: Drop support for IE7 #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16f174
All: Drop support for IE7
scottgonzalez Oct 20, 2014
967bee1
[fixup]: Rename dialog test
scottgonzalez Oct 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions demos/button/toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
padding: 4px;
display: inline-block;
}
/* support: IE7 */
*+html #toolbar {
display: inline;
}
</style>
<script>
$(function() {
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/accordion/accordion.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
font-size: 12px;
line-height: 15px;
}
/* avoid IE7 oscillating between overflow visible and scroll values */
#list1 > div {
overflow: visible;
}
</style>
</head>
<body>
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/dialog/dialog_methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ test("open", function() {
ok(element.dialog("widget").is(":visible") && !element.dialog("widget").is(":hidden"), "dialog visible after open method called");
});

test("#6137: dialog('open') causes form elements to reset on IE7", function() {
// http://bugs.jqueryui.com/ticket/6137
test("Ensure form elements don't reset when opening a dialog", function() {
expect(2);

var d1 = $("<form><input type='radio' name='radio' id='a' value='a' checked='checked'></input>" +
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/dialog/dialog_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,9 @@ test("minWidth", function() {
test( "position, default center on window", function() {
expect( 2 );

// dialogs alter the window width and height in FF and IE7
// dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
// Support: FF, IE7
// Support: Firefox
var winWidth = $( window ).width(),
winHeight = $( window ).height(),
element = $("<div></div>").dialog(),
Expand All @@ -387,9 +387,9 @@ test( "position, default center on window", function() {
test( "position, right bottom at right bottom via ui.position args", function() {
expect( 2 );

// dialogs alter the window width and height in FF and IE7
// dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
// Support: FF, IE7
// Support: Firefox
var winWidth = $( window ).width(),
winHeight = $( window ).height(),
element = $("<div></div>").dialog({
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/menu/menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
}
.ui-menu .ui-menu-item {
padding: 0;
/* Support: IE7 */
*display: block;
*float: left;
*clear: left;
}
#menu3 {
height: 250px;
Expand Down
7 changes: 2 additions & 5 deletions tests/unit/selectable/selectable_events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,9 @@ test( "mousedown: initial position of helper", function() {
clientY: 10
});

// we do a GTE comparison here because IE7 erroneously subtracts
// 2 pixels from a simulated mousedown for clientX/Y
// Support: IE7
helperOffset = $( ".ui-selectable-helper" ).offset();
ok( helperOffset.top >= 99, "Scroll top should be accounted for." );
ok( helperOffset.left >= 99, "Scroll left should be accounted for." );
ok( helperOffset.top, 110, "Scroll top should be accounted for." );
ok( helperOffset.left, 110, "Scroll left should be accounted for." );

// Cleanup
element.simulate( "mouseup" );
Expand Down
1 change: 0 additions & 1 deletion themes/base/accordion.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
position: relative;
margin: 2px 0 0 0;
padding: .5em .5em .5em .7em;
min-height: 0; /* support: IE7 */
font-size: 100%;
}
.ui-accordion .ui-accordion-icons {
Expand Down
3 changes: 0 additions & 3 deletions themes/base/core.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
.ui-helper-clearfix:after {
clear: both;
}
.ui-helper-clearfix {
min-height: 0; /* support: IE7 */
}
.ui-helper-zfix {
width: 100%;
height: 100%;
Expand Down
1 change: 0 additions & 1 deletion themes/base/menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
margin: 0;
padding: 3px 1em 3px .4em;
cursor: pointer;
min-height: 0; /* support: IE7 */
/* support: IE10, see #8844 */
list-style-image: url("data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7");
}
Expand Down
2 changes: 0 additions & 2 deletions themes/base/selectmenu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
}
.ui-selectmenu-menu .ui-menu {
overflow: auto;
/* Support: IE7 */
overflow-x: hidden;
padding-bottom: 1px;
}
.ui-selectmenu-menu .ui-menu .ui-selectmenu-optgroup {
Expand Down
4 changes: 0 additions & 4 deletions ui/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ return $.widget( "ui.tabs", {
return function( anchor ) {
var anchorUrl, locationUrl;

// support: IE7
// IE7 doesn't normalize the href property when set via script (#9317)
anchor = anchor.cloneNode( false );

anchorUrl = anchor.href.replace( rhash, "" );
locationUrl = location.href.replace( rhash, "" );

Expand Down