Skip to content

Build: Remove manifest files; move metadata to source files #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

No description provided.

@tjvantoll
Copy link
Member

For my own benefit what consumes this metadata? The release script? The changes themselves look fine.

@scottgonzalez
Copy link
Member Author

label, group, and description are consumed by download builder. The rest of the metadata was only for the plugin registry, which is no longer being populated. I kept docs and demos because I think we may want to eventually use them in download builder to provide additional context for users.

@tjvantoll
Copy link
Member

Ok that makes sense. And I like keeping docs and demos since we already have that information.

@scottgonzalez
Copy link
Member Author

@rxaviers Can you just confirm that this looks good to land? We'll need to update download builder for 1.12, but this should get us one step closer to the merge.

@rxaviers
Copy link
Member

rxaviers commented Nov 3, 2014

I haven't tested it. But, it does look good if we are ok dropping the category descriptions.

rxaviers added a commit that referenced this pull request Nov 25, 2014
Amend "Build: Remove manifest files; move metadata to source files"
b5f1ffd

Ref gh-1379
@scottgonzalez scottgonzalez deleted the inline-manifest branch February 24, 2015 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants