Skip to content

Build: Remove manifest files; move metadata to source files #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 0 additions & 68 deletions build/core.json

This file was deleted.

46 changes: 0 additions & 46 deletions build/effect.json

This file was deleted.

36 changes: 0 additions & 36 deletions build/interaction.json

This file was deleted.

11 changes: 4 additions & 7 deletions build/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ Release.define({
"}</script>\n\nReleased on " + monthNames[ now.getMonth() ] + " " + now.getDate() + ", " + now.getFullYear() + "\n\n";
},
generateArtifacts: function( fn ) {
var files;
function copyCdnFiles() {
var files = replaceAtVersion();

buildCDNPackage(function copyCdnFiles() {
var zipFile = shell.ls( "../jquery*-cdn.zip" )[ 0 ],
tmpFolder = "../tmp-zip-output",
unzipCommand = "unzip -o " + zipFile + " -d " + tmpFolder;
Expand All @@ -82,11 +83,7 @@ Release.define({
shell.cp( tmpFolder + "/jquery-ui*.js", "dist/cdn" );
shell.cp( "-r", tmpFolder + "/themes", "dist/cdn" );
fn( files );
}

Release.exec( "grunt manifest" );
files = shell.ls( "*.jquery.json" ).concat( replaceAtVersion() );
buildCDNPackage( copyCdnFiles );
});
}
});

Expand Down
92 changes: 0 additions & 92 deletions build/tasks/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,98 +2,6 @@ module.exports = function( grunt ) {

"use strict";

grunt.registerTask( "manifest", "Generate jquery.json manifest files", function() {
var uiFiles,
totalManifests = 0,
pkg = grunt.config( "pkg" ),
base = {
core: {
name: "ui.{plugin}",
title: "jQuery UI {Plugin}"
},
widget: {
name: "ui.{plugin}",
title: "jQuery UI {Plugin}",
dependencies: [ "core", "widget" ]
},
interaction: {
name: "ui.{plugin}",
title: "jQuery UI {Plugin}",
dependencies: [ "core", "widget", "mouse" ]
},
effect: {
name: "ui.effect-{plugin}",
title: "jQuery UI {Plugin} Effect",
keywords: [ "effect", "show", "hide" ],
homepage: "http://jqueryui.com/effect/",
demo: "http://jqueryui.com/effect/",
docs: "http://api.jqueryui.com/{plugin}-effect/",
dependencies: [ "effect" ]
}
};

Object.keys( base ).forEach(function( type ) {
var baseManifest = base[ type ],
plugins = grunt.file.readJSON( "build/" + type + ".json" ),
bower = grunt.file.readJSON( "bower.json" );

Object.keys( plugins ).forEach(function( plugin ) {
var manifest, bowerKey,
data = plugins[ plugin ],
name = plugin.charAt( 0 ).toUpperCase() + plugin.substr( 1 );

function replace( str ) {
return str.replace( "{plugin}", plugin ).replace( "{Plugin}", name );
}

manifest = {
name: data.name || replace( baseManifest.name ),
title: data.title || replace( baseManifest.title ),
description: data.description,
keywords: [ "ui", plugin ]
.concat( baseManifest.keywords || [] )
.concat( data.keywords || [] ),
version: pkg.version,
author: pkg.author,
maintainers: pkg.maintainers,
licenses: pkg.licenses,
bugs: pkg.bugs,
homepage: data.homepage || replace( baseManifest.homepage ||
"http://jqueryui.com/{plugin}/" ),
demo: data.demo || replace( baseManifest.demo ||
"http://jqueryui.com/{plugin}/" ),
docs: data.docs || replace( baseManifest.docs ||
"http://api.jqueryui.com/{plugin}/" ),
download: "http://jqueryui.com/download/",
dependencies: {},
// custom
category: data.category || type
};

for ( bowerKey in bower.dependencies ) {
manifest.dependencies[ bowerKey ] = bower.dependencies[ bowerKey ];
}

(baseManifest.dependencies || [])
.concat(data.dependencies || [])
.forEach(function( dependency ) {
manifest.dependencies[ "ui." + dependency ] = pkg.version;
});

grunt.file.write( manifest.name + ".jquery.json",
JSON.stringify( manifest, null, "\t" ) + "\n" );
totalManifests += 1;
});
});

uiFiles = grunt.file.expand( "ui/*.js" ).length;
if ( totalManifests !== uiFiles ) {
grunt.log.error( "Generated " + totalManifests + " manifest files, but there are " +
uiFiles + " ui/*.js files. Do all of them have entries?" );
return false;
}
});

grunt.registerTask( "clean", function() {
require( "rimraf" ).sync( "dist" );
});
Expand Down
106 changes: 0 additions & 106 deletions build/widget.json

This file was deleted.

Loading