Make widget factory remove classes in destroy #1394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .toggleClass( "ui-state-disabled", value ) | ||
| .attr( "aria-disabled", value ); | ||
| this.button.attr( "aria-disabled", value ); | ||
| this[ ( value ? "_add" : "_remove" ) + "Class" ]( "ui-state-disabled", value ); |
There was a problem hiding this comment.
Why not add a this._toggleClass method? You're doing this a lot over the files.
|
replaced by #1411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the proposed api of _addClass and _removeClass to make them auto remove all classes in destroy
it also add a garbage collection method for the object which tracks classes elements
this changes the api to:
this._addClass( elements, "classes" );It removes the need to differentiate the "extra" classes and tracks all classes and removes all classes in destroy automatically