-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Tests: Replace resource loader with AMD #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reproducing a comment from the original PR, still need to do that: Can we smash all the files in test/unit/helper/ into one js file? I don't see the point in splitting those up when we use them on every page. And you can get rid of the window.require dependency by exporting the right variable: http://requirejs.org/docs/api.html#config var require = { ... }; Would also remove the need to export |
This is ready for a review. I've made a lot of changes from the original implementation. The new implementation significantly reduces the boilerplate for each test. |
grunt-contrib-qunit doesn't support AMD 😢 |
Just went through this with @scottgonzalez on skype every thing looks good. 👍 We also talked about once this lands, seeing what we can extract here including the helpers and common tests to share with mobile. |
Updated master to QUnit 1.18.0. |
Great. I've got a few other tasks to work on right now, but I'll finish this up soon. |
I've squashed most of these commits and rebased on master. New PR is at #1528. |
Replaces gh-1335.
Replaced by gh-1528.
This reduces the changes to only affect the accordion test suite so it's easier to discuss and make changes.
domEqual()
to a real assertionQUnit.assert.close()
with qunit-assert-close moduledomEqual()
to its own moduletests/.jshintrc
domEqual()
changes from Null attributes #1516