Calendar: fix month jumping WIP #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes multiple-month demo and other-month demo.
Do not use value option to pass in a string but value method.
| this.grid.focus(); | ||
| } | ||
|
|
||
| this._setActiveDescendant(); | ||
| }, | ||
|
|
||
| _needsRefresh: function() { | ||
| if ( this.date.month() !== this.viewDate.month() || this.date.year() !== this.viewDate.year() ) { | ||
| return !this.grid.find( |
There was a problem hiding this comment.
This does a basic checking if anything has changed at all (as before, see fnagel@4c2229f#diff-563a5392a566d1a29a68b1b5a37c4cb6L139) and if so, checks if the wanted date is already available within our grid.
There was a problem hiding this comment.
Okay, but why is this extra check needed? That is, under what circumstance do this.date andthis.viewDate` match, but the day isn't rendered?
There was a problem hiding this comment.
Not sure what is meant here. The find() part is needed to make sure we do not have the day available due to eachDay changes (like in other-months demo).
There was a problem hiding this comment.
I see. Can you add that explanation as a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @jzaefferer bug reports regarding the use of multiple-month and other-months demo / option. Some other related issues (with keyboard control) should be fixed now, too. See Datepicker Wiki (ToDo section).
#1316 (comment)
This PR introduces a couple of changes. Mainly removing the selected property from$.date and splitting the $ .date object for ongoing modifications of the current value and the $.date object for the rendering of the grid. The view date object is only updated if we really want to show another month. This split helps fixing issues when dealing with multiple month grids, too.
This is work in progress but I wanted to get some feedback. Not sure if this is a good solution or if I'm missing a simpler way to fix these issues.