Calendar rebase #1316
Calendar rebase #1316
Conversation
| <script src="../../ui/position.js"></script> | ||
| <script src="../../ui/datepicker.js"></script> | ||
| <link rel="stylesheet" href="../demos.css"> | ||
| <script> | ||
| $(function() { | ||
| Globalize.locale( "de-DE" ); |
There was a problem hiding this comment.
This line seems to be needed as the German option has the selected attribute. The display is off when you load this demo.
There was a problem hiding this comment.
Seems valid. See my comment above.
|
I made a few comments on the demo but didn't have a chance to really go through this yet. More comments coming later this weekend. |
| <link rel="stylesheet" href="../demos.css"> | ||
| <script> | ||
| $(function() { | ||
| $( "#datepicker" ).datepicker({ minDate: -20, maxDate: "+1M +10D" }); | ||
| var now = new Date(), |
There was a problem hiding this comment.
This block of code uses spaces not tabs.
|
I had several comments but they're all rather trivial. |
Change status caching, fix existing value related methods, introduce $.date construction with date object, selected property is null by default, add selected getter
Remove shortcut for closing the calendar and erasing the date (CTRL+END)
Several minor code improvements and make suppressExpandOnFocus an internal variable
Add Test if these options are set on the underlying calendar instance.
4538652 to
5a6596d
Compare
Fixed. Chrome fired an additional _calendarEvents focusout event which adds a delayed close. This was related to the regeneration of the buttons in refresh() and flawed logic regarding button() used for prev and next link.
These issues have been a problem before I took over the development and I would like to fix this after we merged this PR. So for now, this is on my to do list. |
|
As long as the remaining open issues are tracked in a public place (at least public to our team), I'm fine with merging this and addressing them later. |
|
@jzaefferer I've updated the Wiki page with all todo's incl. your hints and bugs. Now starting to work on Scott's comments |
This replaces #1281, but was itself replaced by #1352.
Fixed unit tests and cleaner history based on Scott's rebase. Unit tests work in latest FF and Chrome but still fail via grunt. @jzaefferer You mentioned an upcoming improvement for asycTests?